New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use network when explicitly setting network_interfaces #1566

Merged

tpdownes merged 1 commit into GoogleCloudPlatform:develop from tpdownes:htcondor_fix_blueprint

Jul 11, 2023

Member

tpdownes commented Jul 11, 2023

This change becomes necessary after #1553

Submission Checklist

Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cloud HPC Toolkit Contribution guidelines #


          Do not use network when explicitly setting network_interfaces

05bd0dd

tpdownes requested a review from rohitramu

July 11, 2023 19:41

tpdownes assigned rohitramu

rohitramu approved these changes

View reviewed changes

rohitramu assigned tpdownes and unassigned rohitramu

tpdownes merged commit 29075de into GoogleCloudPlatform:develop

tpdownes deleted the htcondor_fix_blueprint branch

July 11, 2023 20:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet