Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make signurl work with objects containing tildes. #783

Merged
merged 1 commit into from
May 20, 2019
Merged

Make signurl work with objects containing tildes. #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gslib/commands/signurl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,8 @@ def RunCommand(self):
# Need to url encode the object name as Google Cloud Storage does when
# computing the string to sign when checking the signature.
gcs_path = '{0}/{1}'.format(
url.bucket_name, urllib.parse.quote(url.object_name.encode(UTF8)))
url.bucket_name,
urllib.parse.quote(url.object_name.encode(UTF8), safe='/~'))

if region == _AUTO_DETECT_REGION:
if url.bucket_name in region_cache:
Expand Down