dracut: Add a new dracut module for gcp udev rules #53
Conversation
ravanelli
commented
May 19, 2023
ravanelli
commented
- The dracut module is required for ignition (https://github.com/coreos/ignition) to work when using Redhat/Fedora CoreOS in GCP. Since the rules are kept in this repository, makes sense for the module to be part of it as well for a better maintenance in case the rules change;
- Modify the spec file to include the new dracut module.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @ravanelli. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
F.Y.I I only tested the changes for google-compute-engine.spec in F38. I didn't validate the changes for debian. Would be good if something could double check it ;) I'm not too familiar with debian packaging. |
|
/cc zmarano |
packaging/debian/install
Outdated
| @@ -4,4 +4,5 @@ etc/rsyslog.d/* | |||
| etc/sysctl.d/* | |||
| lib/udev/rules.d/* | |||
| lib/udev/* | |||
| lib/dracut/* | |||
There was a problem hiding this comment.
Debian doesn't use dracut so please remove this.
There was a problem hiding this comment.
Done. Thanks for checking it @zmarano
|
/ok-to-test |
|
|
||
| # called by dracut | ||
| install() { | ||
| inst_simple /usr/lib/udev/google_nvme_id |
There was a problem hiding this comment.
https://github.com/GoogleCloudPlatform/guest-configs/blob/master/src/lib/udev/google_nvme_id#L20
This script depends on the nvme cli ... which would also have to be included in the dracut module.
There was a problem hiding this comment.
It's probably worth listing all non-coreutils dependencies to be safe. So it would be something like:
inst_multiple nvme grep sed
|
/hold Still missing #53 (comment) |
|
|
||
| # called by dracut | ||
| install() { | ||
| inst_simple /usr/lib/udev/google_nvme_id |
There was a problem hiding this comment.
It's probably worth listing all non-coreutils dependencies to be safe. So it would be something like:
inst_multiple nvme grep sed
- The dracut module is required for ignition (https://github.com/coreos/ignition) to work when using Redhat/Fedora CoreOS in GCP. Since the rules are kept in this repository, makes sense for the module to be part of it as well for a better maintenance in case the rules change; - Modify the spec file to include the new dracut module. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
|
/unhold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravanelli, zmarano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
