tests: add nvme-symlink test to verify GCP udev rules
#2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuijingHei
force-pushed
the
gcp-confidential-test
branch
3 times, most recently
from
cbb46d8
to
e1a8558
Compare
HuijingHei
force-pushed
the
gcp-confidential-test
branch
from
e1a8558
to
8cd6f4f
Compare
|
|
HuijingHei
force-pushed
the
gcp-confidential-test
branch
4 times, most recently
from
cb0c88b
to
6f9e69b
Compare
HuijingHei
force-pushed
the
gcp-confidential-test
branch
from
6f9e69b
to
6a12803
Compare
dustymabe
reviewed
May 23, 2023
HuijingHei
force-pushed
the
gcp-confidential-test
branch
from
6a12803
to
255a0e5
Compare
HuijingHei
force-pushed
the
gcp-confidential-test
branch
from
255a0e5
to
9fcf67f
Compare
|
Need to do some tweak when coreos/coreos-assembler#3484 merged, change |
HuijingHei
force-pushed
the
gcp-confidential-test
branch
from
9fcf67f
to
4664350
Compare
dustymabe
reviewed
May 24, 2023
Force this test to not run by default unless named specifically or `--tag confidential` is passed to `kola run`, also requires `--gcp-machinetype n2d-standard-2 --gcp-confidential-vm` It will create confidential instance on GCP with 1 nvme persistent disk and 1 local ssd disk, then check the new udev rules make effect. Based on coreos/coreos-assembler#3474 and coreos/coreos-assembler#3477. Fix coreos/fedora-coreos-tracker#1457
HuijingHei
force-pushed
the
gcp-confidential-test
branch
from
4664350
to
748f422
Compare
|
Thanks @dustymabe for the review, hold on until coreos/coreos-assembler#3484 merged. |
|
/retest |
|
CI failed because of "downgrade detected" but I think that's just because this PR needs a rebase. I don't think we really need to do that. I'll just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force this test to not run by default unless named specifically
or
--tag confidentialis passed tokola run, also requires--gcp-machinetype n2d-standard-2 --gcp-confidential-vmIt will create confidential instance on GCP with 1 nvme persistent disk
and 1 local ssd disk, then check the new udev rules make effect.
Based on coreos/coreos-assembler#3474
and coreos/coreos-assembler#3477.
Fix coreos/fedora-coreos-tracker#1457