util: put ParseDiskSpec func to util
#3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
HuijingHei
force-pushed
the
util-parsedisk
branch
10 times, most recently
from
f841e42
to
2098727
Compare
HuijingHei
force-pushed
the
util-parsedisk
branch
4 times, most recently
from
c2bc195
to
f865c17
Compare
HuijingHei
force-pushed
the
util-parsedisk
branch
from
f865c17
to
74f7b54
Compare
jlebon
reviewed
May 25, 2023
HuijingHei
force-pushed
the
util-parsedisk
branch
6 times, most recently
from
b2a4002
to
e853e0e
Compare
jlebon
reviewed
May 29, 2023
HuijingHei
force-pushed
the
util-parsedisk
branch
from
8e05ead
to
1c13af6
Compare
HuijingHei
force-pushed
the
util-parsedisk
branch
from
1c13af6
to
0ce5219
Compare
cgwalters
previously approved these changes
May 30, 2023
| @@ -54,7 +54,7 @@ func testMountDisks(c cluster.TestCluster) { | |||
| config := setupIgnitionConfig() | |||
|
|
|||
| options := platform.MachineOptions{ | |||
| AdditionalDisks: []string{"1024M", "1024M"}, | |||
| AdditionalDisks: []string{"1G", "1G"}, | |||
There was a problem hiding this comment.
Hmm tricky...if we were supporting the M specifier before it may be safer to continue doing so.
It looks like all of the external tests use G though.
There was a problem hiding this comment.
That would be better, but we intend to get size as int (trim sufix G) in the ParseDiskSpec func:
- for qemu, need to re-add
Gas it needs string to be passed to qemu-img - for gcp and other cloud, need int, as the default is size in
G
WDYT?
There was a problem hiding this comment.
Yeah, it seems a bit hard to do without re-implementing the suffix parsing here entirely which would be unfortunate.
I think this is OK as is!
HuijingHei
force-pushed
the
util-parsedisk
branch
from
0ce5219
to
894afa5
Compare
Refer to @jlebon's suggestion, see coreos#3477 (comment)
HuijingHei
force-pushed
the
util-parsedisk
branch
from
894afa5
to
246495c
Compare
cgwalters
approved these changes
May 31, 2023
|
Thanks @cgwalters and @jlebon for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to @jlebon's suggestion, see #3477 (comment)