Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use new verify token functionality from google-auth-library #2986

Merged
merged 6 commits into from
Jun 25, 2020
Merged

refactor: use new verify token functionality from google-auth-library #2986

merged 6 commits into from
Jun 25, 2020

Conversation

chingor13
Copy link
Member

@chingor13 chingor13 commented May 28, 2020 •
edited
Loading

google-auth-library 0.21.0 is available, so this is ready to go.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@chingor13 chingor13 requested a review from bshaffer May 28, 2020 22:04
bshaffer
bshaffer reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a draft but this looks fantastic, nice work.

iap/src/main/java/com/example/iap/VerifyIapRequestHeader.java Show resolved Hide resolved
@chingor13 chingor13 marked this pull request as ready for review June 24, 2020 20:53
@chingor13 chingor13 requested a review from a team June 24, 2020 20:53
@chingor13 chingor13 mentioned this pull request Jun 24, 2020
Merged
9 tasks
@chingor13 chingor13 requested a review from bshaffer June 24, 2020 21:22
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
bshaffer
bshaffer approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion and totally up to you. Otherwise, this is double-approved. The net removal of 60 lines of code makes me quite happy.

iap/src/main/java/com/example/iap/VerifyIapRequestHeader.java Show resolved Hide resolved
@chingor13 chingor13 merged commit 8fd9669 into GoogleCloudPlatform:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

@averikitsch averikitsch averikitsch approved these changes

Assignees

@averikitsch averikitsch

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chingor13 @bshaffer @averikitsch @googlebot @kokoro-team