Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iap): cleanup spotbugs warnings #3239

Merged
merged 5 commits into from
Jun 24, 2020
Merged

chore(iap): cleanup spotbugs warnings #3239

merged 5 commits into from
Jun 24, 2020

Conversation

chingor13
Copy link
Member

Fixes the warning from #2986

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@chingor13 chingor13 requested a review from a team June 24, 2020 21:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2020
@chingor13
Copy link
Member Author

Other failing spot bugs errors are no longer present in #2986

@lesv lesv merged commit c3826df into GoogleCloudPlatform:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chingor13 @lesv @googlebot