Custom hash function for router_nat.subnetwork (#2379)

Merged PR #2379.
GoogleCloudPlatform · Sep 25, 2019 · dcc8b59 · dcc8b59
1 parent 07bcde2
commit dcc8b59
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 3 deletions.
diff --git a/build/terraform b/build/terraform
diff --git a/build/terraform-beta b/build/terraform-beta
diff --git a/products/compute/terraform.yaml b/products/compute/terraform.yaml
@@ -1402,6 +1402,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
         is_set: true
       subnetwork: !ruby/object:Overrides::Terraform::PropertyOverride
         is_set: true
+        set_hash_func: computeRouterNatSubnetworkHash
       subnetwork.sourceIpRangesToNat: !ruby/object:Overrides::Terraform::PropertyOverride
         is_set: true
       subnetwork.secondaryIpRangeNames: !ruby/object:Overrides::Terraform::PropertyOverride

diff --git a/templates/terraform/constants/router_nat.go.erb b/templates/terraform/constants/router_nat.go.erb
@@ -62,3 +62,29 @@ func resourceComputeRouterNatDrainNatIpsCustomDiff(diff *schema.ResourceDiff, me
 	}
 	return nil
 }
+
+func computeRouterNatSubnetworkHash(v interface{}) int {
+	obj := v.(map[string]interface{})
+	name := obj["name"]
+	sourceIpRanges := obj["source_ip_ranges_to_nat"]
+	sourceIpRangesHash := 0
+	if sourceIpRanges != nil {
+		sourceIpSet := sourceIpRanges.(*schema.Set)
+
+		for _, ipRange := range sourceIpSet.List() {
+			sourceIpRangesHash += schema.HashString(ipRange.(string))
+		}
+	}
+
+	secondaryIpRangeNames := obj["secondary_ip_range_names"]
+	secondaryIpRangeHash := 0
+	if secondaryIpRangeNames != nil {
+		secondaryIpRangeSet := secondaryIpRangeNames.(*schema.Set)
+
+		for _, secondaryIp := range secondaryIpRangeSet.List() {
+			secondaryIpRangeHash += schema.HashString(secondaryIp.(string))
+		}
+	}
+
+	return schema.HashString(NameFromSelfLinkStateFunc(name)) + sourceIpRangesHash + secondaryIpRangeHash
+}
diff --git a/third_party/terraform/tests/resource_compute_router_nat_test.go.erb b/third_party/terraform/tests/resource_compute_router_nat_test.go.erb
@@ -395,7 +395,7 @@ resource "google_compute_router_nat" "foobar" {
 	nat_ips                            = ["${google_compute_address.foobar.self_link}"]
 	source_subnetwork_ip_ranges_to_nat = "LIST_OF_SUBNETWORKS"
 	subnetwork {
-	  name                    = "${google_compute_subnetwork.foobar.self_link}"
+	  name                    = "${google_compute_subnetwork.foobar.name}"
 	  source_ip_ranges_to_nat = ["ALL_IP_RANGES"]
 	}
 }`, testId, testId, testId, testId, testId)