Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom hash function for router_nat.subnetwork #2379

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Custom hash function for router_nat.subnetwork #2379

merged 3 commits into from
Sep 25, 2019

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Sep 25, 2019 •
edited
Loading

Add custom hash function for router_nat.subnetwork This allows us to … ignore differences between subnetwork name and self_link

Release Note Template for Downstream PRs (will be copied)

compute: fixed perma-diff in `google_compute_router_nat` when referencing subnetwork via `name`

Fixes hashicorp/terraform-provider-google#4513

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 37d8f6d.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1194
depends: hashicorp/terraform-provider-google#4549

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 37d8f6d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@slevenick slevenick force-pushed the router-nat-subnet-name branch from 37d8f6d to 4e7b62a Compare September 25, 2019 22:30
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4e7b62a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick and others added 3 commits September 25, 2019 22:52
@slevenick @modular-magician
Add custom hash function for router_nat.subnetwork This allows us to …
136f582 
…ignore differences between subnetwork name and self_link
@slevenick @modular-magician
Remove extra code
c3ded19
@modular-magician
Update tracked submodules -> HEAD on Wed Sep 25 22:52:35 UTC 2019
2c60473 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit dcc8b59 into GoogleCloudPlatform:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform computes change to google_compute_router_nat based on subnetwork name vs. full self-link
4 participants
@slevenick @modular-magician @rileykarson @googlebot