Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public IP Support for AlloyDB #10331

Merged
merged 15 commits into from
Apr 19, 2024
Merged

Conversation

nancynh
Copy link
Contributor

@nancynh nancynh commented Mar 29, 2024

Description:
Add support to enable public IP on an AlloyDB instance, and set a list of authorized external networks that are able to connect to the public IP of the instance. This PR has some custom code to allow instances to be created with public IP enabled as the API currently prohibits it. I plan on removing this custom code in a future PR once the API is updated, but this shouldn't be a breaking change.

This is for beta and GA terraform support.

Issue:

Release Note Template for Downstream PRs (will be copied)

alloydb: added `network_config` field to `google_alloydb_instance` resource
alloydb: added `public_ip_address` field  to `google_alloydb_instance` resource

@srevinsaju
Copy link
Contributor

G'day! I apologize - but is there an ETA for this change? I had a change on #10100, which got closed in favor of this change - would love to provide any support to get this merged! Thank you!

@nancynh
Copy link
Contributor Author

nancynh commented Apr 5, 2024

Hello! I'm hoping to send this PR for review next Wednesday or Thursday after meeting with the TF team to discuss about internal details on the API and supporting that in TF.

API currently prohibits public IP to be created on instance creation so we have to use the custom code to get around this undesirable behavior in TF. Also removed the more friendly user error messages custom code in the update path in favor of putting the information in the field descriptions.
@nancynh nancynh marked this pull request as ready for review April 12, 2024 00:25
@github-actions github-actions bot requested a review from slevenick April 12, 2024 00:26
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@slevenick
Copy link
Contributor

/gcbrun

@slevenick
Copy link
Contributor

I'm not sure why this is breaking, I'd guess we changed something on main recently. Can you rebase/merge main into this?

@github-actions github-actions bot requested a review from slevenick April 12, 2024 22:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 395 insertions(+))
google-beta provider: Diff ( 3 files changed, 395 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (77 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  network_config = # value needed
  network_config {
    authorized_external_networks = # value needed
  }
  public_ip_address = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 395 insertions(+))
google-beta provider: Diff ( 3 files changed, 395 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (77 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  network_config = # value needed
  network_config {
    authorized_external_networks = # value needed
  }
  public_ip_address = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 21
Skipped tests: 3
Affected tests: 39

Click here to see the affected service packages
  • alloydb

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_alloydbBackupBasicTestExample|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_update|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_restore|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbInstanceBasicTestExample|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_clientConnectionConfig|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbUser_alloydbUserBuiltinTestExample|TestAccAlloydbUser_alloydbUserIamTestExample|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 21
Skipped tests: 3
Affected tests: 39

Click here to see the affected service packages
  • alloydb

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_alloydbBackupBasicTestExample|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_update|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_restore|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbInstanceBasicTestExample|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_clientConnectionConfig|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbUser_alloydbUserBuiltinTestExample|TestAccAlloydbUser_alloydbUserIamTestExample|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 395 insertions(+))
google-beta provider: Diff ( 3 files changed, 395 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (77 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  network_config = # value needed
  network_config {
    authorized_external_networks = # value needed
  }
  public_ip_address = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 21
Skipped tests: 3
Affected tests: 39

Click here to see the affected service packages
  • alloydb

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_alloydbBackupBasicTestExample|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_update|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_restore|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbInstanceBasicTestExample|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_clientConnectionConfig|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbUser_alloydbUserBuiltinTestExample|TestAccAlloydbUser_alloydbUserIamTestExample|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

@nancynh
Copy link
Contributor Author

nancynh commented Apr 15, 2024

Looks like most of them failed due to a quota issue, probably because the e2e test was being run so much as I was making commits. They should pass on a retry. Other than that I forgot the quotes around the cidr_range in my new test

Errors:

    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 50 in region us-central1.",
    "status": "RESOURCE_EXHAUSTED",
    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 5 in region us-east1.",
    "status": "RESOURCE_EXHAUSTED",

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 395 insertions(+))
google-beta provider: Diff ( 3 files changed, 395 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (77 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  network_config = # value needed
  network_config {
    authorized_external_networks = # value needed
  }
  public_ip_address = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 42
Skipped tests: 3
Affected tests: 18

Click here to see the affected service packages
  • alloydb

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_networkConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@slevenick
Copy link
Contributor

Looks like most of them failed due to a quota issue, probably because the e2e test was being run so much as I was making commits. They should pass on a retry. Other than that I forgot the quotes around the cidr_range in my new test

Errors:

    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 50 in region us-central1.",
    "status": "RESOURCE_EXHAUSTED",
    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 5 in region us-east1.",
    "status": "RESOURCE_EXHAUSTED",

Where are you seeing the quota issues? I'm seeing the following:
context deadline exceeded (Client.Timeout exceeded while awaiting headers)

@nancynh
Copy link
Contributor Author

nancynh commented Apr 15, 2024

Looks like most of them failed due to a quota issue, probably because the e2e test was being run so much as I was making commits. They should pass on a retry. Other than that I forgot the quotes around the cidr_range in my new test
Errors:

    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 50 in region us-central1.",
    "status": "RESOURCE_EXHAUSTED",
    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 5 in region us-east1.",
    "status": "RESOURCE_EXHAUSTED",

Where are you seeing the quota issues? I'm seeing the following: context deadline exceeded (Client.Timeout exceeded while awaiting headers)

I see the quota issues in the debug logs. Also see it in us-south1 as well

@slevenick
Copy link
Contributor

/gcbrun cleaned up some extra clusters

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 395 insertions(+))
google-beta provider: Diff ( 3 files changed, 395 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (77 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  network_config = # value needed
  network_config {
    authorized_external_networks = # value needed
  }
  public_ip_address = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 43
Skipped tests: 3
Affected tests: 17

Click here to see the affected service packages
  • alloydb

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@nancynh
Copy link
Contributor Author

nancynh commented Apr 19, 2024

@slevenick Could you take another look at this PR? The VCR tests passed after you cleaned up the project

@slevenick
Copy link
Contributor

The linked issue talks about adding this to the beta provider. Is it supposed to be in GA or only beta? If only beta you will need to mark it as such in the YAML, and add version guards on all the custom code.

@nancynh
Copy link
Contributor Author

nancynh commented Apr 19, 2024

It should be in GA as well. I can create a bug if need be for Github, but on the AlloyDB side we had one filed already to keep track of this

@slevenick slevenick merged commit 70d8eb1 into GoogleCloudPlatform:main Apr 19, 2024
14 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
@nancynh nancynh deleted the public-ip branch June 4, 2024 22:46
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlloyDB public IP assignment in beta provider
4 participants