Update AlloyDB e2e tests and remove custom code for Public-IP feature #10885

nancynh · 2024-06-05T18:18:45Z

Removes the custom code that was in place for the Public-IP feature now that the API supports creating instances with public IP enabled. Users shouldn't see a change in the behavior on TF side - though on the API side we are now enforcing the user to have a complex password to enable public IP. I've also updated the AlloyDB e2e tests relating to the Public-IP feature since they were breaking for the past couple of days from the API change.

Release Note Template for Downstream PRs (will be copied)

alloydb: created the resource `google_alloydb_instance` directly with public IP enabled instead of creating the resource with public IP disabled and then enabling it

…odules into create-public-ip

modular-magician · 2024-06-05T18:29:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))

modular-magician · 2024-06-05T18:32:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))

modular-magician · 2024-06-05T18:33:47Z

Tests analytics

Total tests: 67
Passed tests: 23
Skipped tests: 4
Affected tests: 40

Click here to see the affected service packages

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-06-05T18:34:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))

modular-magician · 2024-06-05T18:37:01Z

Tests analytics

Total tests: 67
Passed tests: 23
Skipped tests: 4
Affected tests: 40

Click here to see the affected service packages

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-06-05T18:38:39Z

Tests analytics

Total tests: 67
Passed tests: 23
Skipped tests: 4
Affected tests: 40

Click here to see the affected service packages

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

github-actions · 2024-06-05T19:26:05Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

No longer needed since we're removing the temporary custom code in place

…odules into create-public-ip

modular-magician · 2024-06-05T19:40:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))

modular-magician · 2024-06-05T19:42:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))

modular-magician · 2024-06-05T19:44:14Z

Tests analytics

Total tests: 67
Passed tests: 23
Skipped tests: 4
Affected tests: 40

Click here to see the affected service packages

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-06-05T19:46:31Z

Tests analytics

Total tests: 67
Passed tests: 23
Skipped tests: 4
Affected tests: 40

Click here to see the affected service packages

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-06-05T19:52:29Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicTestExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_networkConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterPromote[Error message] [Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-06-05T20:19:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicTestExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_networkConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-06-05T20:26:53Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicTestExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_networkConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

nancynh · 2024-06-05T20:48:34Z

FYI the VCR tests are failing due to hitting the quota based on the debug logs:

{
  "error": {
    "code": 429,
    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 50 in region us-central1.",
    "status": "RESOURCE_EXHAUSTED",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.QuotaFailure",
        "violations": [
          {
            "subject": "project:1067888929963",
            "description": "Quota 'ClustersPerProjectPerRegion' exhausted. Limit 50 in region us-central1"
          }
        ]
      }
    ]
  }
}

Errors in the other logs:

            "subject": "project:1067888929963",
            "description": "Quota 'ClustersPerProjectPerRegion' exhausted. Limit 5 in region us-south1"

          {
            "subject": "project:1067888929963",
            "description": "Quota 'ClustersPerProjectPerRegion' exhausted. Limit 5 in region us-east1"
          }

Project could be cleaned up

modular-magician · 2024-06-05T21:10:33Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicTestExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_networkConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-06-05T21:34:30Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicTestExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromote[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Debug log]
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_networkConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinTestExample[Debug log]
TestAccAlloydbUser_alloydbUserIamTestExample[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

zli82016 · 2024-06-05T22:06:49Z

FYI the VCR tests are failing due to hitting the quota based on the debug logs:

{
  "error": {
    "code": 429,
    "message": "Quota limit 'ClustersPerProjectPerRegion' has been exceeded. Limit: 50 in region us-central1.",
    "status": "RESOURCE_EXHAUSTED",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.QuotaFailure",
        "violations": [
          {
            "subject": "project:1067888929963",
            "description": "Quota 'ClustersPerProjectPerRegion' exhausted. Limit 50 in region us-central1"
          }
        ]
      }
    ]
  }
}

Errors in the other logs:

            "subject": "project:1067888929963",
            "description": "Quota 'ClustersPerProjectPerRegion' exhausted. Limit 5 in region us-south1"

          {
            "subject": "project:1067888929963",
            "description": "Quota 'ClustersPerProjectPerRegion' exhausted. Limit 5 in region us-east1"
          }

Project could be cleaned up

Let me check.

zli82016 · 2024-06-05T22:17:47Z

/gcbrun

modular-magician · 2024-06-05T22:28:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 59 deletions(-))

modular-magician · 2024-06-05T22:32:58Z

Tests analytics

Total tests: 67
Passed tests: 63
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

zli82016

LGTM. Thanks.

…GoogleCloudPlatform#10885)

nancynh added 5 commits June 5, 2024 09:04

Remove custom code and update e2e test

bef9f3a

Remove custom code and update e2e test

fc377f6

Remove AlloyDB post-create file and references

8cccf68

Merge branch 'create-public-ip' of https://github.com/nancynh/magic-m…

b7b088d

…odules into create-public-ip

Fix formatting

e44213d

modular-magician added the service/alloydb label Jun 5, 2024

nancynh marked this pull request as ready for review June 5, 2024 19:25

github-actions bot requested a review from zli82016 June 5, 2024 19:26

nancynh added 3 commits June 5, 2024 12:29

Delete post_create AlloyDB file

dabe9e3

No longer needed since we're removing the temporary custom code in place

Fix formatting in tests

3d45d55

Merge branch 'create-public-ip' of https://github.com/nancynh/magic-m…

7538ae7

…odules into create-public-ip

zli82016 approved these changes Jun 6, 2024

View reviewed changes

zli82016 merged commit 9d4ef48 into GoogleCloudPlatform:main Jun 6, 2024
17 checks passed

jessdejong pushed a commit to jessdejong/magic-modules that referenced this pull request Jun 10, 2024

Update AlloyDB e2e tests and remove custom code for Public-IP feature (…

3cda435

…GoogleCloudPlatform#10885)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 24, 2024

Update AlloyDB e2e tests and remove custom code for Public-IP feature (…

6828e63

…GoogleCloudPlatform#10885)

pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024

Update AlloyDB e2e tests and remove custom code for Public-IP feature (…

091c71c

…GoogleCloudPlatform#10885)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update AlloyDB e2e tests and remove custom code for Public-IP feature #10885

Update AlloyDB e2e tests and remove custom code for Public-IP feature #10885

nancynh commented Jun 5, 2024 •

edited

Loading

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

nancynh commented Jun 5, 2024 •

edited

Loading

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

zli82016 commented Jun 5, 2024

zli82016 commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

zli82016 left a comment

Update AlloyDB e2e tests and remove custom code for Public-IP feature #10885

Update AlloyDB e2e tests and remove custom code for Public-IP feature #10885

Conversation

nancynh commented Jun 5, 2024 • edited Loading

modular-magician commented Jun 5, 2024

Diff report

modular-magician commented Jun 5, 2024

Diff report

modular-magician commented Jun 5, 2024

Tests analytics

Action taken

modular-magician commented Jun 5, 2024

Diff report

modular-magician commented Jun 5, 2024

Tests analytics

Action taken

modular-magician commented Jun 5, 2024

Tests analytics

Action taken

github-actions bot commented Jun 5, 2024

modular-magician commented Jun 5, 2024

Diff report

modular-magician commented Jun 5, 2024

Diff report

modular-magician commented Jun 5, 2024

Tests analytics

Action taken

modular-magician commented Jun 5, 2024

Tests analytics

Action taken

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

nancynh commented Jun 5, 2024 • edited Loading

modular-magician commented Jun 5, 2024

modular-magician commented Jun 5, 2024

zli82016 commented Jun 5, 2024

zli82016 commented Jun 5, 2024

modular-magician commented Jun 5, 2024

Diff report

modular-magician commented Jun 5, 2024

Tests analytics

zli82016 left a comment

Choose a reason for hiding this comment

nancynh commented Jun 5, 2024 •

edited

Loading

nancynh commented Jun 5, 2024 •

edited

Loading