Fix Datastream private connection resource destruction

[sagiyosefia]

Fix Datastream private connection resource destruction. The current private connection resource deletion fails as a result of sub resource existence.
This fix will always force the resource deletion, as the sub resources deletion is taking care the the API anyway.

Fixes hashicorp/terraform-provider-google#17290
hashicorp/terraform-provider-google#13054

compute:  fixed issue where sub-resources managed by `google_compute_forwarding_rule` prevented resource deletion

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[ScottSuarez]

Are your routes not managed through terraform?

I can see why this behavior might be needed but if everything is within terraform this should be a non-issue.

We could potentially make this opt in but let me understand your usecase before I suggest anything.

[joshbautista]

Are your routes not managed through terraform?

@ScottSuarez More details in hashicorp/terraform-provider-google#17290 but the gist is:

The following supporting resources are not managed or created explicitly by Terraform when instantiating a google_datastream_private_connection:

• VPC Peering Connection with a Google owned VPC
• VPC Peering Routes
• Allocated IP Range for Private Services Access

From what I can tell, the Datastream API takes it upon itself to manage the lifecycle of these resources on your behalf and doesn't expect (or possibly want) the end user to have created these resources beforehand.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+))
google-beta provider: Diff ( 1 file changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 3
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages

• datastream

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test