Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Datastream private connection resource destruction #11394

Merged
merged 1 commit into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/products/datastream/PrivateConnection.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ custom_code: !ruby/object:Provider::Terraform::CustomCode
constants: templates/terraform/constants/private_connection.go.erb
post_create: templates/terraform/post_create/private_connection.go.erb
post_import: templates/terraform/post_import/private_connection.go.erb
pre_delete: templates/terraform/pre_delete/private_connection.go.erb
ScottSuarez marked this conversation as resolved.
Show resolved Hide resolved
parameters:
- !ruby/object:Api::Type::String
name: privateConnectionId
Expand Down
5 changes: 5 additions & 0 deletions mmv1/templates/terraform/pre_delete/private_connection.go.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Add force=true query param to force deletion of private connection sub resources like Routes
url, err = transport_tpg.AddQueryParams(url, map[string]string{"force": strconv.FormatBool(true)})
if err != nil {
return err
}
Loading