-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoted labelFingerprint field to GA #11504
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3900 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
I see expected error in the VCR tests: |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3900 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
remaining test failures are unrelated |
I believe I've deleted the resources causing the quota issues. /gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
opened hashicorp/terraform-provider-google#19199 to track the failures. |
Tests analyticsTotal tests: 3900 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
…n-FEATURE-BRANCH-6.0.0 * commit 'bc5def9f8136003836911e78567dc8849a39be6d': Fix test `TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule` (GoogleCloudPlatform#11469) Promoted labelFingerprint field to GA (GoogleCloudPlatform#11504) Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#11485) Support Undelete for Vmwareengine Private Cloud (GoogleCloudPlatform#11480)
Fixed hashicorp/terraform-provider-google#18739.
This required writing a new Update test, so I implemented a PlanCheck to verify there was no deletion as described in hashicorp/terraform-provider-google#12428 (comment) The first commit intentionally forces recreate of the resource to show the PlanCheck works.
Release Note Template for Downstream PRs (will be copied)