Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoted labelFingerprint field to GA #11504

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

melinath
Copy link
Member

@melinath melinath commented Aug 20, 2024

Fixed hashicorp/terraform-provider-google#18739.

This required writing a new Update test, so I implemented a PlanCheck to verify there was no deletion as described in hashicorp/terraform-provider-google#12428 (comment) The first commit intentionally forces recreate of the resource to show the PlanCheck works.

Release Note Template for Downstream PRs (will be copied)

compute: added `label_fingerprint` field to `google_compute_global_address` resource (ga)
compute: fixed bug where the `labels` field could not be updated on `google_compute_global_address` (ga)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 107 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3900
Passed tests: 3518
Skipped tests: 379
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_storagePoolSpecified
  • TestAccComputeGlobalAddress_update
  • TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeGlobalAddress_update[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@melinath
Copy link
Member Author

I see expected error in the VCR tests: expected no deletion of resources, but google_compute_global_address.foobar has planned deletion

@melinath melinath requested a review from trodge August 20, 2024 22:27
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 107 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3900
Passed tests: 3518
Skipped tests: 379
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_storagePoolSpecified
  • TestAccComputeGlobalAddress_update
  • TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeGlobalAddress_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@melinath melinath requested a review from c2thorn August 21, 2024 15:00
@melinath
Copy link
Member Author

remaining test failures are unrelated

@melinath
Copy link
Member Author

I believe I've deleted the resources causing the quota issues. /gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 107 insertions(+), 1 deletion(-))

@melinath
Copy link
Member Author

opened hashicorp/terraform-provider-google#19199 to track the failures.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3900
Passed tests: 3520
Skipped tests: 379
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProjectIamPolicy_invalidMembers[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@melinath melinath merged commit cec6d62 into GoogleCloudPlatform:main Aug 21, 2024
13 checks passed
@melinath melinath deleted the tpg-18739 branch August 21, 2024 17:07
c2thorn added a commit to c2thorn/magic-modules that referenced this pull request Aug 21, 2024
…n-FEATURE-BRANCH-6.0.0

* commit 'bc5def9f8136003836911e78567dc8849a39be6d':
  Fix test `TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule` (GoogleCloudPlatform#11469)
  Promoted labelFingerprint field to GA (GoogleCloudPlatform#11504)
  Revert "Prevent Dataflow options in parameters" (GoogleCloudPlatform#11485)
  Support Undelete for Vmwareengine Private Cloud (GoogleCloudPlatform#11480)
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when adding labels to existing google_compute_global_address
4 participants