Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoted labelFingerprint field to GA #2693

Conversation

modular-magician
Copy link
Collaborator

Fixed hashicorp/terraform-provider-google#18739.

This required writing a new Update test, so I implemented a PlanCheck to verify there was no deletion as described in hashicorp/terraform-provider-google#12428 (comment) The first commit intentionally forces recreate of the resource to show the PlanCheck works.

Release Note Template for Downstream PRs (will be copied)

compute: added `label_fingerprint` field to `google_compute_global_address` resource (ga)
compute: fixed bug where the `labels` field could not be updated on `google_compute_global_address` (ga)

Derived from GoogleCloudPlatform/magic-modules#11504

[upstream:cec6d62e04abfb41a334e8b07d481e3e3076abde]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner August 21, 2024 16:59
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team August 21, 2024 16:59
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 3bfdaa4 into GoogleCloudPlatform:main Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when adding labels to existing google_compute_global_address
1 participant