Ansible Catchup #145

rambleraptor · 2018-05-02T00:28:59Z

The final catchup PR! This merges in Ansible commits, brings in Ansible resource override support, and fixes some misc bugs on Puppet/Chef DNS.

Corresponding Ansible PR: https://github.com/modular-magician/ansible/pull/1/commits

Take a look at the last two commits in particular, since that's new code. This is a large PR, so let me know how to best split this up.

[all]

Ansible Catchup as of 20180501

[terraform]

[puppet]

[puppet-dns]

Moving quota to NestedObject

[puppet-sql]

[puppet-compute]

[chef]

This involves changes to pass module around so that input:true properties can pick up on it. Change-Id: I4913accdb988e5eb051626e08b7115feaee2aebd

Change-Id: I3c4b3a4e1083f38803744d890bf3d86963041c50

This also adds support for NameValues Change-Id: Iba8513f382a7a18da983cb987829fcbd640f94c7

Change-Id: Id301f6521c61306f7534f9fb580821a4e4a0184c

Change-Id: I96b968df0a5cb0086bd729df075499f5e1b55510

Change-Id: Id0da7cf24540e692c627119ea5be4890ec19cbb1

Change-Id: I64a3ff47163c1c151ebe4826bd0ca0f902571979

Change-Id: I79fe83666821521eae652d18d05fa6839559c47b

Change-Id: If1de77011d1c1055d915541413a16e12d7e96795

Change-Id: Ice3076b7c47b66e1c5529900e4cab317cb5c1e00

Change-Id: I20806546d8263819093af14964ee4eeeb2fed59b

Change-Id: Ifc26d50a5f91a2946c05db5176a3d7bd8cb79241

Change-Id: Ibacca5e151fc50817edb103fd3b85a0cc982f819

Change-Id: Iee42d18e0c562f4c880978a77b566f8f07e7c287

nat-henderson · 2018-05-02T00:53:57Z

This PR crashes terraform generation (so the magician will never show up to comment). Any idea what might be going on there?

rambleraptor · 2018-05-02T05:43:49Z

Good call. Not sure how I missed that last time around.

Made a change that I'm fairly positive fixes it. Made a poor assumption about how overrides are working.

modular-magician · 2018-05-02T06:01:07Z

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/puppet-google-compute#25

rosbo · 2018-05-02T16:43:34Z

templates/ansible/resource.erb

@@ -272,11 +269,11 @@ def resource_to_request(module):
 <%
  encoder_name = if object.encoder?
                   object.transport.encoder
-                 else config['encoder']
-                   config['encoder']
+                 else object.encoder


Why is there a condition for a else statement here?

Fixed. (object.encoder was the name for a custom encoder, changed to make more explicit)

(But actually fixed now)

nelsonjr · 2018-05-02T20:36:34Z

.gitmodules

@@ -66,7 +66,8 @@
 	url = git@github.com:GoogleCloudPlatform/chef-google-logging
 [submodule "build/ansible"]
 	path = build/ansible
-	url = git@github.com:ansible/ansible.git
+	url = git@github.com:modular-magician/ansible


fix tabs/spaces.

nelsonjr · 2018-05-02T20:48:27Z

products/dns/api.yaml

-        description: |
-          Maximum allowed size for total rrdata in one ChangesCreateRequest
-          in bytes.
+      - !ruby/object:Api::Type::NestedObject


You need to add an entry to puppet.yaml and chef.yaml to warn about this change.

What did you mean by this?

Updated.

(Chef DNS did not previously have a changelog).

nelsonjr · 2018-05-02T20:49:06Z

provider/ansible/resource_override.rb

+        default_value_property :exclude, false
+        default_value_property :editable, true
+        default_value_property :imports, []
+        default_value_property :provider_helpers, []

        check_property :access_api_results, :boolean


Check all properties.

modular-magician · 2018-05-03T18:38:53Z

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 083793b) have been included in your existing downstream PRs.

rosbo · 2018-05-03T19:45:32Z

products/compute/ansible.yaml

-  Firewall: !ruby/object:Provider::Ansible::ResourceOverride
-    exclude: true
+  BackendService: !ruby/object:Provider::Ansible::ResourceOverride
+    aliases:


Should be a property override.

properties:
timeoutSec:
aliases: ['timeout_seconds']

Good call! Fixed. Much more property_override driven.

rosbo

👍 for the overrides usage.

Change-Id: I5ad6ecf1344621cb40d4123dfc80cc5861c28c8d

modular-magician · 2018-05-03T22:17:40Z

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 4e08b98) have been included in your existing downstream PRs.

Change-Id: Ida223aca0a6ddecc7918b6a3d82c117953fe9af8

rambleraptor added 14 commits May 1, 2018 20:02

Ansible: Input: true properties should use module values

990353f

This involves changes to pass module around so that input:true properties can pick up on it. Change-Id: I4913accdb988e5eb051626e08b7115feaee2aebd

Adding GcpRequestException back and fetch_wrapped_resource change

a4a4e9e

Change-Id: I3c4b3a4e1083f38803744d890bf3d86963041c50

Ansible: Instance

f32b6e5

This also adds support for NameValues Change-Id: Iba8513f382a7a18da983cb987829fcbd640f94c7

Ansible: Compute Instance Template

01e3f15

Change-Id: Id301f6521c61306f7534f9fb580821a4e4a0184c

Ansible: Compute Target HTTPS Proxy

c7356d8

Change-Id: I96b968df0a5cb0086bd729df075499f5e1b55510

Ansible: Compute Instance Group Manager

d6e19ff

Change-Id: Id0da7cf24540e692c627119ea5be4890ec19cbb1

Ansible: Compute Target SSL Proxy

8342cc7

Change-Id: I64a3ff47163c1c151ebe4826bd0ca0f902571979

Ansible: Compute Firewall

0b57656

Change-Id: I79fe83666821521eae652d18d05fa6839559c47b

Ansible: Adding HTTPHealthCheck alias for checkIntervalSec

c4fc4ba

Change-Id: If1de77011d1c1055d915541413a16e12d7e96795

Ansible: Selflink + collection for resourcerefs

9f0844d

Change-Id: Ice3076b7c47b66e1c5529900e4cab317cb5c1e00

Ansible: Outputting description fields using a YAML dumper

4d3e886

Change-Id: I20806546d8263819093af14964ee4eeeb2fed59b

Ansible: Resource to request ignore input=false parameters

9fab127

Change-Id: Ifc26d50a5f91a2946c05db5176a3d7bd8cb79241

DNS - changing quota to use nested property

0eba2b0

Change-Id: Ibacca5e151fc50817edb103fd3b85a0cc982f819

Override support for Ansible

a27c7b5

Change-Id: Iee42d18e0c562f4c880978a77b566f8f07e7c287

rambleraptor requested review from nelsonjr, rosbo, nat-henderson and danawillow May 2, 2018 00:37

rambleraptor force-pushed the catchup branch from a324c5c to 7898c53 Compare May 2, 2018 05:42

rambleraptor mentioned this pull request May 2, 2018

Ansible: Backend Bucket Fixes #146

Merged

rosbo reviewed May 2, 2018

View reviewed changes

rosbo mentioned this pull request May 2, 2018

Default values on properties #148

Merged

nelsonjr suggested changes May 2, 2018

View reviewed changes

rambleraptor force-pushed the catchup branch from 7898c53 to 4c16d7c Compare May 3, 2018 18:15

modular-magician added the downstream-generated label May 3, 2018

rosbo suggested changes May 3, 2018

View reviewed changes

rambleraptor force-pushed the catchup branch 4 times, most recently from c73a415 to 5efed2f Compare May 3, 2018 20:29

rosbo approved these changes May 3, 2018

View reviewed changes

rambleraptor force-pushed the catchup branch from 5efed2f to 796c127 Compare May 3, 2018 20:38

Changing Ansible to point to our fork

04cb1ac

Change-Id: I5ad6ecf1344621cb40d4123dfc80cc5861c28c8d

rambleraptor force-pushed the catchup branch from 796c127 to 04cb1ac Compare May 3, 2018 22:05

nelsonjr approved these changes May 3, 2018

View reviewed changes

modular-magician added the downstream-generated label May 3, 2018

Changing Ansible commit

f7f68b6

Change-Id: Ida223aca0a6ddecc7918b6a3d82c117953fe9af8

rambleraptor merged commit 219d0cb into GoogleCloudPlatform:master May 4, 2018

rambleraptor deleted the catchup branch May 4, 2018 07:02

danawillow mentioned this pull request Nov 21, 2018

[Terraform] sql private ip support #938

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ansible Catchup #145

Ansible Catchup #145

rambleraptor commented May 2, 2018

nat-henderson commented May 2, 2018

rambleraptor commented May 2, 2018

modular-magician commented May 2, 2018

rosbo May 2, 2018

rosbo May 3, 2018

rambleraptor May 3, 2018

rambleraptor May 3, 2018

nelsonjr May 2, 2018

rambleraptor May 3, 2018

nelsonjr May 2, 2018

rambleraptor May 3, 2018

rambleraptor May 3, 2018

nelsonjr May 2, 2018

rambleraptor May 3, 2018

modular-magician commented May 3, 2018

rosbo May 3, 2018

rambleraptor May 3, 2018

rosbo left a comment

modular-magician commented May 3, 2018

Ansible Catchup #145

Ansible Catchup #145

Conversation

rambleraptor commented May 2, 2018

[all]

[terraform]

[puppet]

[puppet-dns]

[puppet-sql]

[puppet-compute]

[chef]

nat-henderson commented May 2, 2018

rambleraptor commented May 2, 2018

modular-magician commented May 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented May 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rosbo left a comment

Choose a reason for hiding this comment

modular-magician commented May 3, 2018