Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terraform] sql private ip support #938

Merged
merged 13 commits into from
Nov 21, 2018
Merged

[Terraform] sql private ip support #938

merged 13 commits into from
Nov 21, 2018

Conversation

danawillow
Copy link
Contributor

Based off of hashicorp/terraform-provider-google-beta#145

[all]

[terraform]

Website changes for SQL private IP + new computed field

[terraform-beta]

Close this PR in favor of #145.

[ansible]

[inspec]

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@danawillow
Copy link
Contributor Author

This code is in a third party directory not subject to Google's CLA rules.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#150
depends: hashicorp/terraform-provider-google#2509

@danawillow danawillow requested a review from chrisst November 21, 2018 17:24
craigdbarber
craigdbarber approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@craigdbarber craigdbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

jimmy-huang-ck and others added 13 commits November 21, 2018 18:52
@modular-magician modular-magician merged commit c4ca58e into master Nov 21, 2018
@danawillow danawillow deleted the tf-pr-145 branch December 7, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigdbarber craigdbarber craigdbarber approved these changes

@chrisst chrisst Awaiting requested review from chrisst

Assignees
No one assigned
Labels
automerged cla: no downstream-generated terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danawillow @googlebot @modular-magician @craigdbarber @jimmy-huang-ck @yhuang