-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for node_locations to google_container_node_pool. #2320
Add support for node_locations to google_container_node_pool. #2320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just some docs things - also conversion looks like it needs a rebase
@@ -131,6 +131,15 @@ type-specific `region` for regional clusters / `zone` for zonal clusters. | |||
See the [official documentation](https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr) | |||
for more information. | |||
|
|||
* `node_locations` - (Optional) The list of zones in which the node pool's nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, Beta?
cluster = "${google_container_cluster.cluster.name}" | ||
|
||
initial_node_count = 1 | ||
node_locations = ["us-central1-a", "us-central1-c"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nbd whitespace is the worst
5735541
to
cef8432
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
The Magician is using an ugly diffbase, and I can't get it to clean itself up (unless I was to delete the downstreams). Merging with ugly diffs. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
cef8432
to
9009193
Compare
Fixes hashicorp/terraform-provider-google#3992
Release Note for Downstream PRs (will be copied)