add description field to service_account for Terraform #2435

tmshn · 2019-10-06T16:41:00Z

I've added the description field to resource google_service_account

ref:

Release Note Template for Downstream PRs (will be copied)

`The length of the `description` field of `google_service_account` is now limited to 256 characters.

modular-magician · 2019-10-06T23:41:17Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@tysen, please review this PR or find an appropriate assignee.

tmshn · 2019-10-29T06:12:08Z

@ndmckinley Should I close this PR due to #2513 ?

nat-henderson · 2019-10-29T17:41:36Z

Yours is definitely the better version of this PR. I'll let @tysen decide what to do - maybe we should undo that PR and merge this one instead?

tmshn · 2019-10-30T03:34:52Z

@ndmckinley As another choice; I'm happy to merge master and resolve conflicts between our codes ( time.Sleep(time.Second) is something missing in my code).

tysen · 2019-10-30T18:05:11Z

As another choice; I'm happy to merge master and resolve conflicts between our codes ( time.Sleep(time.Second) is something missing in my code).

@tmshn - That sounds like a good plan to me.

tmshn · 2019-10-31T13:20:33Z

@tysen resolved 3b1671c

tysen · 2019-11-05T00:03:49Z

Looks like there's some errors in the build.

tmshn · 2019-12-07T09:32:46Z

Looks like there's some errors in the build.

@tysen Sorry I didn't notice that! That's just a typo, now fixed: 1798ab1

tmshn · 2019-12-07T09:53:34Z

And I solved the conflict with #2650 by @ndmckinley (actually his new logic is almost equivalent to mine, so the diff against master is getting smaller).

tysen · 2019-12-09T20:33:41Z

third_party/terraform/resources/resource_google_service_account.go

-		}).Do()
-	if err != nil {
-		return err
+	if len(updateMask) > 0 {


What's the motivation behind these changes to ..Update? I'm not sure the Terraform SDK would call into ..Update without a diff.

Ah... this happened during merging #2650 by @ndmckinley into my original code 81c263d, but well you are right, we don't need this.

fixed c979aa1

third_party/terraform/tests/resource_google_service_account_test.go

modular-magician · 2019-12-10T22:48:19Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c979aa1.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.

tysen

This validation isn't strictly correct - the docs say "Must be less than or equal to 256 UTF-8 bytes" (bytes, not characters) but I think it's still useful given that 256 single byte characters is the upper bound for what the API would accept.

I'll merge this shortly.

tysen · 2019-12-10T23:31:44Z

Merging failed - @tmshn do you mind rebasing?

tmshn · 2019-12-30T06:17:47Z

@tysen

This validation isn't strictly correct - the docs say "Must be less than or equal to 256 UTF-8 bytes" (bytes, not characters)

len against string in Golang returns bytes count, which means valiation.StringLenBetween validates based on bytes count rather than characters count. So I think the validation is correct, isn't it? (maybe I should change the text for release note?)

Merging failed - @tmshn do you mind rebasing?

Rebased (commit history is now cleaned).
(I should have abandoned this PR earlier and open new one only to add validation...sorry to make the situation complicated.)

modular-magician · 2020-01-14T23:55:04Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6ce8bbb.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1646
depends: hashicorp/terraform-provider-google#5409
depends: modular-magician/inspec-gcp#319

(setting empty value tend to be more buggy than setting other values)

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Oct 6, 2019

modular-magician added the community label Oct 6, 2019

tysen reviewed Dec 9, 2019

View reviewed changes

tmshn commented Dec 10, 2019

View reviewed changes

third_party/terraform/tests/resource_google_service_account_test.go Show resolved Hide resolved

tmshn force-pushed the service-account-description branch 2 times, most recently from 6c94752 to c979aa1 Compare December 10, 2019 03:41

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels Dec 10, 2019

tysen approved these changes Dec 10, 2019

View reviewed changes

modular-magician added the automerged label Dec 10, 2019

tmshn force-pushed the service-account-description branch from c979aa1 to 5b31ba9 Compare December 30, 2019 06:10

tmshn force-pushed the service-account-description branch from 5b31ba9 to 6ce8bbb Compare December 30, 2019 06:22

modular-magician added the inspec label Jan 14, 2020

tmshn and others added 3 commits January 15, 2020 00:07

add length validation for service_account description

35e8d24

tiny fix on test of service_account description

46318c6

(setting empty value tend to be more buggy than setting other values)

Update tracked submodules -> HEAD on Wed Jan 15 00:07:35 UTC 2020

9070e95

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the service-account-description branch from 6ce8bbb to 9070e95 Compare January 15, 2020 00:07

modular-magician merged commit 2b3126e into GoogleCloudPlatform:master Jan 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add description field to service_account for Terraform #2435

add description field to service_account for Terraform #2435

tmshn commented Oct 6, 2019 •

edited by tysen

Loading

modular-magician commented Oct 6, 2019

tmshn commented Oct 29, 2019

nat-henderson commented Oct 29, 2019

tmshn commented Oct 30, 2019

tysen commented Oct 30, 2019

tmshn commented Oct 31, 2019

tysen commented Nov 5, 2019

tmshn commented Dec 7, 2019

tmshn commented Dec 7, 2019

tysen Dec 9, 2019

tmshn Dec 10, 2019

tmshn Dec 10, 2019 •

edited

Loading

modular-magician commented Dec 10, 2019 •

edited by slevenick

Loading

tysen left a comment

tysen commented Dec 10, 2019

tmshn commented Dec 30, 2019 •

edited

Loading

modular-magician commented Jan 14, 2020

add description field to service_account for Terraform #2435

add description field to service_account for Terraform #2435

Conversation

tmshn commented Oct 6, 2019 • edited by tysen Loading

modular-magician commented Oct 6, 2019

tmshn commented Oct 29, 2019

nat-henderson commented Oct 29, 2019

tmshn commented Oct 30, 2019

tysen commented Oct 30, 2019

tmshn commented Oct 31, 2019

tysen commented Nov 5, 2019

tmshn commented Dec 7, 2019

tmshn commented Dec 7, 2019

tysen Dec 9, 2019

Choose a reason for hiding this comment

tmshn Dec 10, 2019

Choose a reason for hiding this comment

tmshn Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

modular-magician commented Dec 10, 2019 • edited by slevenick Loading

Pull request statuses

New Pull Requests

tysen left a comment

Choose a reason for hiding this comment

tysen commented Dec 10, 2019

tmshn commented Dec 30, 2019 • edited Loading

modular-magician commented Jan 14, 2020

Pull request statuses

New Pull Requests

tmshn commented Oct 6, 2019 •

edited by tysen

Loading

tmshn Dec 10, 2019 •

edited

Loading

modular-magician commented Dec 10, 2019 •

edited by slevenick

Loading

tmshn commented Dec 30, 2019 •

edited

Loading