Add description to service account. #2513
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
| Etag: sa.Etag, | ||
| }).Do() | ||
| if err != nil { | ||
| return fmt.Errorf("Error updating service account %q: %s", d.Id(), err) | ||
| } | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
Seeing sleep's in a test makes me uncomfortable, sleep's in production code much more so. Is this only to make the test pass?
There was a problem hiding this comment.
Nope, the test passes about 70% of the time without it. It's just that this api is only mostly synchronous. This is more than enough time to get a consistent result, which is good for users and tests. Costs very little, even though it's terrible practice.
There was a problem hiding this comment.
Oh dear. Can you add a comment inline otherwise without context I can see this being removed by a well meaning future developer.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
svc-acct-desc
branch
from
74eaf7f to
21e5f14
Compare
Release Note Template for Downstream PRs (will be copied)
Also deflakes the unit tests by introducing a sleep next to synchronous operations (which aren't that synchronous...)