Add GKE Resource Consumption Metering, promote resource export to GA #2705
Conversation
…source Export block to GA
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
|
Sorry about the delay on my end! I've been busy with |
| @@ -881,6 +881,20 @@ func resourceContainerCluster() *schema.Resource { | |||
| Optional: true, | |||
| Default: false, | |||
| }, | |||
| "enable_resource_consumption_metering": { | |||
There was a problem hiding this comment.
Can you break this schema out so that it's just the following? As well as make the required transformations in code to send/read the right request. enable_shielded_nodes is an example where we made a similar transformation, I believe.
"enable_resource_consumption_metering": {
Type: schema.TypeBool,
Optional: true,
Default: true,
},
(defaulting to whatever the API does)
There was a problem hiding this comment.
OK, I'm trying to find the time for this - I'm having a hard time figuring how to nest the Shielded style code into another resource block.
I do think more fields are coming to this block in the future, in case that matters.
There was a problem hiding this comment.
I'm not aware of any additional subfields upcoming, so I'd rather we pull it up. We can add them in a compatible way if any are added.
hashicorp/terraform-provider-google-beta@6e56d74 is a good reference for what adding enable_shielded_nodes looked like (although it's munged with shielded_instance_config. Only the parts in google_container_cluster.go matter.)
|
superseded with #3303 |
Add GKE Resource Consumption Metering, promote resource export block to GA
Should resolve hashicorp/terraform-provider-google#4634
Relates to terraform-google-modules/terraform-google-kubernetes-engine#316
Release Note Template for Downstream PRs (will be copied)