Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GKE metering (now in GA) for all module and submodule versions #316

Closed
gcamus59 opened this issue Nov 12, 2019 · 3 comments
Closed

add GKE metering (now in GA) for all module and submodule versions #316

gcamus59 opened this issue Nov 12, 2019 · 3 comments
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@gcamus59
Copy link
Contributor

gcamus59 commented Nov 12, 2019

GKE metering is not anymore a Beta feature, it's now in General Availability.
So, the feature should be available for use in every kind of modules.

It's already available in the beta' module versions. It seems that moving the code outside from the beta_cluster IF conditions (inside the autogen repository) will enable the feature for all module versions.

After beginning work on the modification in a pull request, I saw that the parameter is not yet available in the non beta google Terraform provider (see hashicorp/terraform-provider-google#4634)

@morgante
Copy link
Contributor

Thanks, this should be easy to fix once hashicorp/terraform-provider-google#4634 is resolved.

@thomas-riccardi
Copy link

hashicorp/terraform-provider-google@a646d86 is now included in google 3.16.0.

Also, would it be possible to make enable_network_egress_metering configurable (which is set to true here whereas in the provider it defaults to false)? (And maybe enable_resource_consumption_metering too for completeness).

@morgante morgante added P3 medium priority issues triaged Scoped and ready for work and removed upstream Work required on Terraform core or provider labels Apr 8, 2020
@gcamus59
Copy link
Contributor Author

Thanks, I'll work on it this week and I will craft a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

4 participants