-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fully configurable resource usage export block in GA #491
feat: Add fully configurable resource usage export block in GA #491
Conversation
Waiting your feedback regarding the requirement of the Google provider in 3.16+ version (is it the right implementation for this kind fo new feature only available in the latest google provider versions, should I update other tests cases requirements, etc..) |
Yes I think its reasonable to bump provider versions. In fact I think we should be doing |
In terms of upgrading provider versions:
|
autogen/main/variables.tf.tmpl
Outdated
@@ -188,6 +188,12 @@ variable "node_pools_metadata" { | |||
default-node-pool = {} | |||
} | |||
} | |||
|
|||
variable "resource_usage_export" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of switching to a direct object list (which is also a very confusing data type), we should retain the existing resource_usage_export_dataset_id
variable and add enable_network_egress_export
and enable_resource_consumption_export
variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the feedback. I'll update it.
LGTM, CI error seems unrelated but there are some conflicts. Please rebase |
…grade GCP provider
…grade GCP provider (terraform-google-modules#491) BREAKING CHANGE: Minimum Google provider version increased to 3.16.
Add GKE metering block which it's now in GA into Google Provider version since 3.16.
In the previous implementation on the BETA modules, only the BigQuery dataset was editable. In this version, all parameters can be updated such as:
See #316