Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable Instance changes #3102

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

danawillow
Copy link
Contributor

  • instance_type and display_name are now updatable
  • don't detect drift on instance_type to prepare for API changes
  • get rid of customdiff for development instances because they sort of compare against config but sort of compare against state and I just think we're going to see more problems with it down the line especially if there are upcoming API changes

Release Note Template for Downstream PRs (will be copied)

* bigtable: added update support for `display_name` and `instance_type`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 77 deletions(-))
Terraform Beta: Diff ( 2 files changed, 30 insertions(+), 77 deletions(-))

@danawillow danawillow merged commit 44641cf into GoogleCloudPlatform:master Feb 11, 2020
@danawillow danawillow deleted the bt-instancetype branch February 11, 2020 18:21
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
* make instancetype and displayname updatable, stop detecting drift on instancetype

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants