Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable Instance changes #1751

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Bigtable Instance changes #1751

merged 1 commit into from
Feb 11, 2020

Conversation

modular-magician
Copy link
Collaborator

  • instance_type and display_name are now updatable
  • don't detect drift on instance_type to prepare for API changes
  • get rid of customdiff for development instances because they sort of compare against config but sort of compare against state and I just think we're going to see more problems with it down the line especially if there are upcoming API changes

Release Note Template for Downstream PRs (will be copied)

* bigtable: added update support for `display_name` and `instance_type`

Derived from GoogleCloudPlatform/magic-modules#3102

@modular-magician
Bigtable Instance changes (hashicorp#3102)
b4426c3 
* make instancetype and displayname updatable, stop detecting drift on instancetype

* update tests

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/m label Feb 11, 2020
@modular-magician modular-magician merged commit 1c07fbb into hashicorp:master Feb 11, 2020
@modular-magician modular-magician deleted the downstream-pr-44641cfbb58a2c6bb56d47a36b5c5f4236cb5d7b branch November 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician