Added Artifact Registry product

[ardagnir]

Adds support for Artifact Registry

Fixes hashicorp/terraform-provider-google#5928.

Release Note Template for Downstream PRs (will be copied)

`google_artifact_registry_repository` beta-only

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 10 files changed, 1439 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 231 insertions(+))

[chrisst]

Thanks for adding this! I have just a couple minor fixes.

[chrisst]

We are moving to using location for resources especially when the url path uses the same naming. It also looks like this may support locations like us or europe based on the output of https://artifactregistry.googleapis.com/v1beta1/projects/{{project}}/locations

[ardagnir]

Changing region->location breaks the autogenerated iam code. I tried changing around the settings but it always gives the following error:

Error: Import id "" doesn't match any of the accepted formats: [projects/(?P[^/]+)/locations/(?P[^/]+)/repositories/(?P[^/]+) (?P[^/]+)/(?P[^/]+)/(?P[^/]+) (?P[^/]+)/(?P[^/]+)]

[chrisst]

You can update the IAM import format to use location as well. See https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/cloudrun/api.yaml#L241-L245 as an example.

[ardagnir]

Fixed, thanks! Was going in a completely wrong direction because of the empty string in the error message. Fixed that too.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 10 files changed, 1439 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 231 insertions(+))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 10 files changed, 1433 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 231 insertions(+))

[lindsayismith]

What happens when we upgrade to v1? Do we have multiple version of this, or just change this string?

[chrisst]

If there are multiple APIs we try to keep multiple versions specified here. That will generate terraform-provider-google-beta which will call into the beta API and terraform-provider-google which will call the v1 endpoints. In the future if fields are added to the beta API that haven't made it to v1 we can support those.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 11 files changed, 1441 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))

[chrisst]

I added the links to website side-bar and if the build passes it looks good. Thanks!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1458 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))