-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Artifact Registry product #3360
Merged
chrisst
merged 5 commits into
GoogleCloudPlatform:master
from
ardagnir:artifact-registry
Apr 22, 2020
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
24d3315
Added artifact registry product
ardagnir 474d549
Artifact Registry fixes
ardagnir 3a443e0
Switched property from region -> location
ardagnir aeace1e
Add artifact registry links to website
chrisst 362d241
Merge branch 'master' into artifact-registry
chrisst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
# Copyright 2020 Google Inc. | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
--- !ruby/object:Api::Product | ||
name: ArtifactRegistry | ||
display_name: Artifact Registry | ||
scopes: | ||
- https://www.googleapis.com/auth/cloud-platform | ||
versions: | ||
- !ruby/object:Api::Product::Version | ||
name: beta | ||
base_url: https://artifactregistry.googleapis.com/v1beta1/ | ||
apis_required: | ||
- !ruby/object:Api::Product::ApiReference | ||
name: Artifact Registry API | ||
url: https://console.cloud.google.com/apis/library/artifactregistry.googleapis.com/ | ||
async: !ruby/object:Api::OpAsync | ||
operation: !ruby/object:Api::OpAsync::Operation | ||
path: 'name' | ||
base_url: '{{op_id}}' | ||
wait_ms: 1000 | ||
result: !ruby/object:Api::OpAsync::Result | ||
path: 'response' | ||
resource_inside_response: true | ||
status: !ruby/object:Api::OpAsync::Status | ||
path: 'done' | ||
complete: true | ||
allowed: | ||
- true | ||
- false | ||
error: !ruby/object:Api::OpAsync::Error | ||
path: 'error' | ||
message: 'message' | ||
objects: | ||
- !ruby/object:Api::Resource | ||
name: 'Repository' | ||
base_url: projects/{{project}}/locations/{{location}}/repositories | ||
create_url: projects/{{project}}/locations/{{location}}/repositories?repository_id={{repository_id}} | ||
min_version: beta | ||
description: A repository for storing artifacts | ||
references: !ruby/object:Api::Resource::ReferenceLinks | ||
guides: | ||
'Official Documentation': | ||
'https://cloud.google.com/artifact-registry/docs/overview' | ||
api: 'https://cloud.google.com/artifact-registry/docs/reference/rest/' | ||
iam_policy: !ruby/object:Api::Resource::IamPolicy | ||
exclude: false | ||
method_name_separator: ':' | ||
parent_resource_attribute: 'repository' | ||
import_format: ["projects/{{project}}/locations/{{location}}/repositories/{{repository}}", "{{repository}}"] | ||
properties: | ||
- !ruby/object:Api::Type::String | ||
name: name | ||
description: |- | ||
The name of the repository, for example: | ||
"projects/p1/locations/us-central1/repositories/repo1" | ||
ardagnir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
output: true | ||
- !ruby/object:Api::Type::String | ||
name: repository_id | ||
description: |- | ||
The last part of the repository name, for example: | ||
"repo1" | ||
required: true | ||
input: true | ||
url_param_only: true | ||
- !ruby/object:Api::Type::String | ||
name: 'location' | ||
description: | | ||
The name of the location this repository is located in. | ||
required: true | ||
input: true | ||
url_param_only: true | ||
- !ruby/object:Api::Type::Enum | ||
name: format | ||
description: |- | ||
The format of packages that are stored in the repoitory. | ||
values: | ||
- :DOCKER | ||
ardagnir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
required: true | ||
input: true | ||
- !ruby/object:Api::Type::String | ||
name: description | ||
description: |- | ||
The user-provided description of the repository. | ||
- !ruby/object:Api::Type::KeyValuePairs | ||
name: 'labels' | ||
description: | | ||
Labels with user-defined metadata. | ||
This field may contain up to 64 entries. Label keys and values may be no | ||
longer than 63 characters. Label keys must begin with a lowercase letter | ||
and may only contain lowercase letters, numeric characters, underscores, | ||
and dashes. | ||
- !ruby/object:Api::Type::Time | ||
name: createTime | ||
description: The time when the repository was created. | ||
output: true | ||
- !ruby/object:Api::Type::Time | ||
name: updateTime | ||
description: The time when the repository was last updated. | ||
output: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright 2019 Google Inc. | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
--- !ruby/object:Provider::Terraform::Config | ||
overrides: !ruby/object:Overrides::ResourceOverrides | ||
Repository: !ruby/object:Overrides::Terraform::ResourceOverride | ||
id_format: projects/{{project}}/locations/{{location}}/repositories/{{repsitory_id}} | ||
autogen_async: true | ||
examples: | ||
- !ruby/object:Provider::Terraform::Examples | ||
name: "artifact_registry_repository_basic" | ||
min_version: 'beta' | ||
primary_resource_id: "my-repo" | ||
vars: | ||
repository_id: "my-repository" | ||
description: "example docker repository" | ||
- !ruby/object:Provider::Terraform::Examples | ||
name: "artifact_registry_repository_iam" | ||
min_version: 'beta' | ||
primary_resource_id: "my-repo" | ||
vars: | ||
account_id: "my-account" | ||
repository_id: "my-repository" | ||
description: "example docker repository with iam" | ||
ardagnir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
properties: | ||
location: !ruby/object:Overrides::Terraform::PropertyOverride | ||
required: false | ||
default_from_api: true | ||
repository_id: !ruby/object:Overrides::Terraform::PropertyOverride | ||
custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb' | ||
name: !ruby/object:Overrides::Terraform::PropertyOverride | ||
custom_expand: 'templates/terraform/custom_expand/shortname_to_url.go.erb' | ||
custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb' |
8 changes: 8 additions & 0 deletions
8
templates/terraform/examples/artifact_registry_repository_basic.tf.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
resource "google_artifact_registry_repository" "<%= ctx[:primary_resource_id] %>" { | ||
provider = google-beta | ||
|
||
location = "us-central1" | ||
repository_id = "<%= ctx[:vars]['repository_id'] %>" | ||
description = "<%= ctx[:vars]['description'] %>" | ||
format = "DOCKER" | ||
} |
24 changes: 24 additions & 0 deletions
24
templates/terraform/examples/artifact_registry_repository_iam.tf.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
resource "google_artifact_registry_repository" "<%= ctx[:primary_resource_id] %>" { | ||
provider = google-beta | ||
|
||
location = "us-central1" | ||
repository_id = "<%= ctx[:vars]['repository_id'] %>" | ||
description = "<%= ctx[:vars]['description'] %>" | ||
format = "DOCKER" | ||
} | ||
|
||
resource "google_service_account" "test-account" { | ||
provider = google-beta | ||
|
||
account_id = "<%= ctx[:vars]['account_id'] %>" | ||
display_name = "Test Service Account" | ||
} | ||
|
||
resource "google_artifact_registry_repository_iam_member" "test-iam" { | ||
provider = google-beta | ||
|
||
location = google_artifact_registry_repository.<%= ctx[:primary_resource_id] %>.location | ||
repository = google_artifact_registry_repository.<%= ctx[:primary_resource_id] %>.name | ||
role = "roles/artifactregistry.reader" | ||
member = "serviceAccount:${google_service_account.test-account.email}" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when we upgrade to v1? Do we have multiple version of this, or just change this string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are multiple APIs we try to keep multiple
versions
specified here. That will generate terraform-provider-google-beta which will call into the beta API and terraform-provider-google which will call the v1 endpoints. In the future if fields are added to the beta API that haven't made it to v1 we can support those.