Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cloud SQL high availability flag documentation #3477

Merged
merged 2 commits into from
May 6, 2020
Merged

Update Cloud SQL high availability flag documentation #3477

merged 2 commits into from
May 6, 2020

Conversation

rileykarson
Copy link
Member

Upstreams hashicorp/terraform-provider-google#6254

Release Note Template for Downstream PRs (will be copied)

Kodyc1 added 2 commits May 6, 2020 09:46
@Kodyc1 @rileykarson
Update High Availability flag to mention Cloud SQL instances
4bb4e05 
This line mentions only Postgres but the flag should apply to MySQL as well: * `availability_type` - (Optional) This specifies whether a PostgreSQL instance should be set up for high availability (`REGIONAL`) or single zone (`ZONAL`).

The REST API (https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1beta4/instances#sqlavailabilitytype) doesn't say it's Postgres specific.
@Kodyc1 @rileykarson
Availability type wording
2558103 
Adding @rileykarson's suggestions
@rileykarson rileykarson requested a review from slevenick May 6, 2020 16:55
@rileykarson rileykarson changed the title Update high availability flag documentation in Cloud SQL Update Cloud SQL high availability flag documentation May 6, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))

@rileykarson rileykarson merged commit 6e513e6 into GoogleCloudPlatform:master May 6, 2020
@rileykarson rileykarson deleted the ksqldoc branch May 6, 2020 17:02
@modular-magician modular-magician mentioned this pull request May 6, 2020
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@rileykarson
Update Cloud SQL high availability flag documentation (GoogleCloudPla…
1f7b789 
…tform#3477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rileykarson @modular-magician @slevenick @googlebot @Kodyc1