Update High Availability flag to mention Cloud SQL instances #6254
Conversation
This line mentions only Postgres but the flag should apply to MySQL as well: * `availability_type` - (Optional) This specifies whether a PostgreSQL instance should be set up for high availability (`REGIONAL`) or single zone (`ZONAL`). The REST API (https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1beta4/instances#sqlavailabilitytype) doesn't say it's Postgres specific.
ghost
requested review from
| @@ -240,7 +240,7 @@ The required `settings` block supports: | |||
| for information on how to upgrade to Second Generation instances. | |||
| A list of Google App Engine (GAE) project names that are allowed to access this instance. | |||
|
|
|||
| * `availability_type` - (Optional) This specifies whether a PostgreSQL instance | |||
| * `availability_type` - (Optional) This specifies whether a Cloud SQL instance | |||
There was a problem hiding this comment.
Seems reasonable to me! While you're here, what do you think of changing it to the following:
The availability type of the Cloud SQL instance, high availability (`REGIONAL`) or single zone (`ZONAL`).'
That displays the actual reference docs' message ("The availability type of the given Cloud SQL instance.") while still listing both options concisely.
There was a problem hiding this comment.
Definitely a concise improvement - changed per your suggestion!
Adding @rileykarson's suggestions
|
Ah, never mind about the delay. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
This line mentions only Postgres but the flag should apply to MySQL as well: *
availability_type- (Optional) This specifies whether a PostgreSQL instance should be set up for high availability (REGIONAL) or single zone (ZONAL).The REST API (https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1beta4/instances#sqlavailabilitytype) doesn't say it's Postgres specific.