Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update High Availability flag to mention Cloud SQL instances #6254

Merged
merged 2 commits into from
May 6, 2020
Merged

Update High Availability flag to mention Cloud SQL instances #6254

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a8a7a6
Update High Availability flag to mention Cloud SQL instances
Kodyc1 Apr 30, 2020
21b923e
Availability type wording
Kodyc1 May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/docs/r/sql_database_instance.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ The required `settings` block supports:
for information on how to upgrade to Second Generation instances.
A list of Google App Engine (GAE) project names that are allowed to access this instance.

* `availability_type` - (Optional) This specifies whether a PostgreSQL instance
* `availability_type` - (Optional) This specifies whether a Cloud SQL instance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! While you're here, what do you think of changing it to the following:

The availability type of the Cloud SQL instance, high availability (`REGIONAL`) or single zone (`ZONAL`).'

That displays the actual reference docs' message ("The availability type of the given Cloud SQL instance.") while still listing both options concisely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a concise improvement - changed per your suggestion!

should be set up for high availability (`REGIONAL`) or single zone (`ZONAL`).

* `crash_safe_replication` - (Optional, Deprecated) This property is only applicable to First Generation instances.
Expand Down