Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gRPC healthchecks #3825

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 5, 2020

Release Note Template for Downstream PRs (will be copied)

Fixes: hashicorp/terraform-provider-google#6826

compute: added grpc_health_check block to compute_health_check
compute: added grpc_health_check block to compute_region_health_check

@google-cla google-cla bot added the cla: yes label Aug 5, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 440 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 4 files changed, 440 insertions(+), 10 deletions(-))
Ansible: Diff ( 4 files changed, 325 insertions(+))
TF Conversion: Diff ( 2 files changed, 124 insertions(+))
Inspec: Diff ( 5 files changed, 63 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 686 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 6 files changed, 686 insertions(+), 10 deletions(-))
Ansible: Diff ( 4 files changed, 325 insertions(+))
TF Conversion: Diff ( 2 files changed, 124 insertions(+))
TF OiCS: Diff ( 16 files changed, 448 insertions(+))
Inspec: Diff ( 5 files changed, 63 insertions(+))

@upodroid
Copy link
Contributor Author

@rileykarson can i get this merged? Thanks

@rileykarson
Copy link
Member

Whoops- sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gRPC health checks
3 participants