-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grpc healthcheck behaviour. #3883
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 32 insertions(+), 2 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140696" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceDNSKeys_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceComputeImage|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeNodeTypes_basic|TestAccComputeRegions_basic|TestAccComputeZones_basic|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceComputeSslCertificate|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceGoogleVpnGateway|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryTableIamMemberGenerated|TestAccBigQueryTableIamPolicyGenerated|TestAccBigQueryTableIamBindingGenerated_withCondition|TestAccBigQueryTableIamMemberGenerated_withCondition|TestAccBigQueryTableIamPolicyGenerated_withCondition|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccComputeInstanceIamBindingGenerated|TestAccComputeInstanceIamMemberGenerated|TestAccComputeInstanceIamBindingGenerated_withCondition|TestAccComputeInstanceIamMemberGenerated_withCondition|TestAccComputeInstanceIamPolicyGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamBindingGenerated|TestAccComputeInstanceIamPolicyGenerated_withCondition|TestAccComputeSubnetworkIamBindingGenerated_withCondition|TestAccComputeSubnetworkIamPolicyGenerated|TestAccComputeSubnetworkIamMemberGenerated_withCondition|TestAccComputeSubnetworkIamPolicyGenerated_withCondition|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapWebBackendServiceIamBindingGenerated|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccIapWebBackendServiceIamMemberGenerated|TestAccIapWebBackendServiceIamBindingGenerated_withCondition|TestAccIapWebBackendServiceIamMemberGenerated_withCondition|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccIapWebBackendServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccStorageBucketIamBindingGenerated|TestAccStorageBucketIamMemberGenerated|TestAccStorageBucketIamBindingGenerated_withCondition|TestAccStorageBucketIamMemberGenerated_withCondition|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccBigQueryDataset_basic|TestAccBigQueryDataset_bigqueryDatasetBasicExample|TestAccBigQueryDataset_datasetWithContents|TestAccBigQueryDataset_access|TestAccBigQueryDataset_regionalLocation|TestAccBigQueryJob_bigqueryJobQueryExample|TestAccBigQueryJob_bigqueryJobQueryTableReferenceExample|TestAccBigQueryJob_bigqueryJobLoadExample|TestAccBigQueryJob_bigqueryJobLoadTableReferenceExample|TestAccBigQueryJob_bigqueryJobExtractExample|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccBigQueryDatasetAccess_view|TestAccBigQueryDatasetAccess_iamMember|TestAccBigQueryDatasetAccess_basic|TestAccBigQueryDatasetAccess_allUsers|TestAccBigQueryDatasetAccess_allAuthenticatedUsers You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140699" |
😄 i'm getting better with newer PRs that i'm submitting. |
@upodroid All good! I assumed I'd confirmed the tests when I LGTMed in the first place. |
Make up for the fact that past!Riley did not run the tests for #3825
Followup for hashicorp/terraform-provider-google#6826
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)