Add NotificationConfig to google_container_cluster

[freddd]

This PR aims to introduce the new beta attribute NotificationConfig to google_container_cluster. This is the issue I created in the terraform provider (though in the wrong provider, I should've added it to the beta provider): hashicorp/terraform-provider-google#7337

In order to test this PR I ran:

• bundle exec compiler -a -v "beta" -e terraform -o "$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta" to generate the provider
• make test in the provider
• make lint in the provider
• rake test in magic modules

References:

• https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-upgrade-notifications?hl=el
• https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters#Cluster.NotificationConfig

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added `notification_config` to `google_container_cluster`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

[freddd]

Ping @megan07 - this is the PR to replace hashicorp/terraform-provider-google#7338. I can't seem to add you as a reviewer.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 31 insertions(+))
Terraform Beta: Diff ( 2 files changed, 225 insertions(+), 2 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 225 insertions(+), 2 deletions(-))

[megan07]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148414"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 225 insertions(+), 2 deletions(-))

[megan07]

Hi @freddd! This looks great! Just a few comments on the tests and I think we'll be ready to merge!
Thank you!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 202 insertions(+), 2 deletions(-))

[megan07]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148612"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 202 insertions(+), 2 deletions(-))

[freddd]

I can't seem to see why it failed. Cloud build is stating You do not have sufficient permissions to view this page and I can't seem to log into https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148612.

[megan07]

Hi @freddd! Sorry for the confusion, I run our entire test suite against previously recorded responses from the API to check that no other tests have been affected - and recently that run has been timing out and showing a failure, but I double-check them and will let you know if there are any errors to worry about. Thanks again!

[megan07]

Sorry, I missed this! This shouldn't be in quotes, we want to extrapolate the value from google_pubsub_topic.%s.id, we don't want that string here. Then it should be good!

[freddd]

No worries! I removed the quotes in 3862c14

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 202 insertions(+), 2 deletions(-))

[megan07]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=149151"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 202 insertions(+), 2 deletions(-))

[megan07]

Looks great! Tests pass! Thank you!!