Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NotificationConfig to google_container_cluster #2521

Conversation

modular-magician
Copy link
Collaborator

This PR aims to introduce the new beta attribute NotificationConfig to google_container_cluster. This is the issue I created in the terraform provider (though in the wrong provider, I should've added it to the beta provider): hashicorp/terraform-provider-google#7337

In order to test this PR I ran:

  • bundle exec compiler -a -v "beta" -e terraform -o "$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta" to generate the provider
  • make test in the provider
  • make lint in the provider
  • rake test in magic modules

References:

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added `notification_config` to `google_container_cluster`

Derived from GoogleCloudPlatform/magic-modules#4012

* Added NotificationConfig on google_container_cluster (beta)

* fixed generated code

* added example

* forgot != ga on expand func

* deleted example & refactored tests

* removed quotes

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0994290 into hashicorp:master Sep 28, 2020
@modular-magician modular-magician deleted the downstream-pr-0a760b36e13e1111060da477cf3d09c11f38f90a branch November 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant