Promote Managed SSL to GA + Doc fixes

[upodroid]

Fixes: hashicorp/terraform-provider-google#7828
Fixes: hashicorp/terraform-provider-google#7832

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `google_compute_managed_ssl_certificate` to GA

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[c2thorn]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=158668"

[c2thorn]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=158685"

[c2thorn]

Moving this to GA caused MM to try to generate this for Ansible. I believe it needs to be excluded here:
https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/compute/ansible.yaml#L327

[upodroid]

Ah, that explains why generate-diffs was broken

[c2thorn]

let's try again!

[c2thorn]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=158690"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 830 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 5 files changed, 22 insertions(+), 48 deletions(-))
Ansible: Diff ( 2 files changed, 6 insertions(+))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 21 deletions(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[c2thorn]

https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/common_diff_suppress.go.erb#L140 needs to be made available for GA as well, the build is failing because of this

[upodroid]

I fixed and tested it properly

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 833 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 5 files changed, 22 insertions(+), 58 deletions(-))
Ansible: Diff ( 2 files changed, 6 insertions(+))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 26 deletions(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 833 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 5 files changed, 22 insertions(+), 58 deletions(-))
Ansible: Diff ( 2 files changed, 6 insertions(+))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 26 deletions(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[c2thorn]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=160869"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 833 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 5 files changed, 22 insertions(+), 58 deletions(-))
Ansible: Diff ( 2 files changed, 6 insertions(+))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 26 deletions(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[c2thorn]

@upodroid thanks for your patience on this, but I think we are at a good point now.

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccCloudSchedulerJob_schedulerJobHttpExample|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=160874"