Promote Managed SSL to GA + Doc fixes

products/cloudscheduler/api.yaml

@@ -273,6 +273,8 @@ objects:
               HTTP request body. 
               A request body is allowed only if the HTTP method is POST or PUT. 
               It will result in invalid argument error to set a body on a job with an incompatible HttpMethod.
+
+              A base64-encoded string.
             required: false
             input: true
           - !ruby/object:Api::Type::KeyValuePairs
@@ -311,6 +313,8 @@ objects:
               HTTP request body. 
               A request body is allowed only if the HTTP method is POST, PUT, or PATCH. 
               It is an error to set body on a job with an incompatible HttpMethod.
+
+              A base64-encoded string.
             required: false
           - !ruby/object:Api::Type::KeyValuePairs
             name: headers

products/compute/ansible.yaml

@@ -372,6 +372,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
     exclude: true
   VpnGateway: !ruby/object:Overrides::Ansible::ResourceOverride
     exclude: true
+  ManagedSslCertificate: !ruby/object:Overrides::Ansible::ResourceOverride
+    exclude: true
 files: !ruby/object:Provider::Config::Files
   resource:
 <%= lines(indent(compile('provider/ansible/resource~compile.yaml'), 4)) -%>

products/compute/api.yaml

@@ -13241,7 +13241,6 @@ objects:
     # GCP resource as the preceding certificate object.
     name: 'ManagedSslCertificate'
     kind: 'compute#sslCertificate'
-    min_version: beta
     base_url: projects/{{project}}/global/sslCertificates
     collection_url_key: 'items'
     references: !ruby/object:Api::Resource::ReferenceLinks

products/compute/terraform.yaml

@@ -2167,10 +2167,9 @@ overrides: !ruby/object:Overrides::ResourceOverrides
           http_health_check_name: "http-health-check"
       - !ruby/object:Provider::Terraform::Examples
         name: "managed_ssl_certificate_recreation"
-        primary_resource_id: "default"
+        primary_resource_id: "cert"
         # Random provider
         skip_vcr: true
-        min_version: beta
     description: |
       {{description}}
       For a resource where you provide the key, see the

templates/terraform/examples/managed_ssl_certificate_basic.tf.erb

@@ -1,6 +1,4 @@
 resource "google_compute_managed_ssl_certificate" "default" {
-  provider = google-beta
-
   name = "<%= ctx[:vars]['cert_name'] %>"
 
   managed {
@@ -9,16 +7,12 @@ resource "google_compute_managed_ssl_certificate" "default" {
 }
 
 resource "google_compute_target_https_proxy" "default" {
-  provider = google-beta
-
   name             = "<%= ctx[:vars]['proxy_name'] %>"
   url_map          = google_compute_url_map.default.id
   ssl_certificates = [google_compute_managed_ssl_certificate.default.id]
 }
 
 resource "google_compute_url_map" "default" {
-  provider = google-beta
-
   name        = "<%= ctx[:vars]['url_map_name'] %>"
   description = "a description"
 
@@ -41,8 +35,6 @@ resource "google_compute_url_map" "default" {
 }
 
 resource "google_compute_backend_service" "default" {
-  provider = google-beta
-
   name        = "<%= ctx[:vars]['backend_service_name'] %>"
   port_name   = "http"
   protocol    = "HTTP"
@@ -52,40 +44,27 @@ resource "google_compute_backend_service" "default" {
 }
 
 resource "google_compute_http_health_check" "default" {
-  provider = google-beta
-
   name               = "<%= ctx[:vars]['http_health_check_name'] %>"
   request_path       = "/"
   check_interval_sec = 1
   timeout_sec        = 1
 }
 
 resource "google_dns_managed_zone" "zone" {
-  provider = google-beta
-
   name     = "<%= ctx[:vars]['dns_zone_name'] %>"
   dns_name = "sslcert.tf-test.club."
 }
 
 resource "google_compute_global_forwarding_rule" "default" {
-  provider = google-beta
-
   name       = "<%= ctx[:vars]['forwarding_rule_name'] %>"
   target     = google_compute_target_https_proxy.default.id
   port_range = 443
 }
 
 resource "google_dns_record_set" "set" {
-  provider = google-beta
-
   name         = "sslcert.tf-test.club."
   type         = "A"
   ttl          = 3600
   managed_zone = google_dns_managed_zone.zone.name
   rrdatas      = [google_compute_global_forwarding_rule.default.ip_address]
-}
-
-provider "google-beta" {
-  region = "us-central1"
-  zone   = "us-central1-a"
-}
+}

templates/terraform/examples/managed_ssl_certificate_recreation.tf.erb

@@ -2,7 +2,6 @@
 // recreate the ssl certificate and update the target https proxy correctly
 
 resource "google_compute_target_https_proxy" "default" {
-  provider = google-beta
   name             = "test-proxy"
   url_map          = google_compute_url_map.default.id
   ssl_certificates = [google_compute_managed_ssl_certificate.cert.id]
@@ -22,7 +21,6 @@ resource "random_id" "certificate" {
 }
 
 resource "google_compute_managed_ssl_certificate" "cert" {
-  provider = google-beta
   name     = random_id.certificate.hex
 
   lifecycle {
@@ -35,7 +33,6 @@ resource "google_compute_managed_ssl_certificate" "cert" {
 }
 
 resource "google_compute_url_map" "default" {
-  provider = google-beta
   name            = "url-map"
   description     = "a description"
   default_service = google_compute_backend_service.default.id
@@ -54,7 +51,6 @@ resource "google_compute_url_map" "default" {
 }
 
 resource "google_compute_backend_service" "default" {
-  provider = google-beta
   name          = "backend-service"
   port_name     = "http"
   protocol      = "HTTP"
@@ -63,7 +59,6 @@ resource "google_compute_backend_service" "default" {
 }
 
 resource "google_compute_http_health_check" "default" {
-  provider = google-beta
   name               = "http-health-check"
   request_path       = "/"
   check_interval_sec = 1

templates/terraform/examples/scheduler_job_http.tf.erb

@@ -12,5 +12,6 @@ resource "google_cloud_scheduler_job" "job" {
   http_target {
     http_method = "POST"
     uri         = "https://example.com/ping"
+    body        = base64encode("{"foo":"bar"}")
   }
 }

third_party/terraform/utils/common_diff_suppress.go.erb

@@ -136,7 +136,6 @@ func locationDiffSuppressHelper(a, b string) bool {
 		strings.Replace(a, "/locations/", "/zones/", 1) == b
 }
 
-<% unless version == 'ga' -%>
 // For managed SSL certs, if new is an absolute FQDN (trailing '.') but old isn't, treat them as equals.
 func absoluteDomainSuppress(k, old, new string, _ *schema.ResourceData) bool {
 	if strings.HasPrefix(k, "managed.0.domains.") {
@@ -145,6 +144,7 @@ func absoluteDomainSuppress(k, old, new string, _ *schema.ResourceData) bool {
 	return old == new
 }
 
+<% unless version == 'ga' -%>
 func timestampDiffSuppress(format string) schema.SchemaDiffSuppressFunc {
 	return func(_, old, new string, _ *schema.ResourceData) bool {
 		oldT, err := time.Parse(format, old)