Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add runtimeconfig variable data source #4475

Conversation

brandonjbjelland
Copy link
Contributor

@brandonjbjelland brandonjbjelland commented Feb 6, 2021

What is this change?

This PR adds a data source for google_runtimeconfig_variable as requested on this issue.

Checklist

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes). Comment here.
  • Generated Terraform, and ran rake test and rake lint to ensure it passes unit and linter tests. - unrelated failure in products/appengine/api.yaml.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_new_datasource`

@google-cla
Copy link

google-cla bot commented Feb 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 6, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@brandonjbjelland
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 6, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 123 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 123 insertions(+), 1 deletion(-))

@brandonjbjelland brandonjbjelland force-pushed the feat/add-runtimeconfig-variable-datasource branch from e1b8de8 to 6d6efcc Compare February 7, 2021 10:51
@brandonjbjelland
Copy link
Contributor Author

brandonjbjelland commented Feb 8, 2021

Question: It looks like all the runtimeconfig resources are still beta in our docs but the related resources look like they landed in both the GA and beta providers (including the work here). Should the data source in this changeset only ship to beta, and if so, how to do that exactly?

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171669"

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171677"

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171678"

@brandonjbjelland brandonjbjelland force-pushed the feat/add-runtimeconfig-variable-datasource branch from 97863c3 to a2e88a4 Compare February 9, 2021 23:35
@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171681"

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171682"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 49 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 132 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 49 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 131 insertions(+), 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 49 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 131 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 49 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 132 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 48 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 131 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 48 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 132 insertions(+), 2 deletions(-))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171685"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 48 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 131 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRuntimeconfigVariableDatasource_basic|TestAccEssentialContactsContact_essentialContactExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171691"

@ScottSuarez ScottSuarez merged commit 1e2d9e0 into GoogleCloudPlatform:master Feb 10, 2021
@brandonjbjelland brandonjbjelland deleted the feat/add-runtimeconfig-variable-datasource branch February 10, 2021 18:14
venkykuberan pushed a commit to venkykuberan/magic-modules that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants