-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add runtimeconfig variable data source #4475
feat: add runtimeconfig variable data source #4475
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
@googlebot I signed it! |
e1b8de8
to
6d6efcc
Compare
Question: It looks like all the |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171669" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171677" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171678" |
97863c3
to
a2e88a4
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171681" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171682" |
1 similar comment
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171685" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRuntimeconfigVariableDatasource_basic|TestAccEssentialContactsContact_essentialContactExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171691" |
What is this change?
This PR adds a data source for
google_runtimeconfig_variable
as requested on this issue.Checklist
If this PR is for Terraform, I acknowledge that I have:
rake test
andrake lint
to ensure it passes unit and linter tests. - unrelated failure inproducts/appengine/api.yaml
.Release Note Template for Downstream PRs (will be copied)