Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add runtimeconfig variable data source #2945

Conversation

modular-magician
Copy link
Collaborator

What is this change?

This PR adds a data source for google_runtimeconfig_variable as requested on this issue.

Checklist

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes). Comment here.
  • Generated Terraform, and ran rake test and rake lint to ensure it passes unit and linter tests. - unrelated failure in products/appengine/api.yaml.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_new_datasource`

Derived from GoogleCloudPlatform/magic-modules#4475

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/m label Feb 10, 2021
@modular-magician modular-magician merged commit 5b05054 into hashicorp:master Feb 10, 2021
@modular-magician modular-magician deleted the downstream-pr-1e2d9e08de4fa99f5f3933736e6492c698701fb7 branch November 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant