Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventarc Trigger #4476

Merged
merged 10 commits into from
Feb 18, 2021
Merged

Eventarc Trigger #4476

merged 10 commits into from
Feb 18, 2021

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Feb 6, 2021

Add eventarc resource as the first DCL-based resource.

Lots of handwritten parts that can be cleaned up in the future when tpgtools+mmv1 are better integrated

Currently DCL-based resources fail VCR testing because the client is copied & saved during client creation, making us unable to swap during testing

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_eventarc_trigger

@google-cla google-cla bot added the cla: yes label Feb 6, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 178 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 38 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171309"

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 178 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 38 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171309"

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 178 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 38 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171311"

@slevenick
Copy link
Contributor Author

/gcbrun

1 similar comment
@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 8 files changed, 179 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 3 files changed, 38 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171312"

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 178 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 38 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171313"

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 13 files changed, 951 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 3 files changed, 38 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171314"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 43 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 13 files changed, 951 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 4 files changed, 39 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171461"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 32 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 13 files changed, 952 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171462"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 32 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 14 files changed, 928 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171668"

@slevenick
Copy link
Contributor Author

/gcbrun

to pull new DCL version

@slevenick slevenick changed the title Eventarc Trigger [DO NOT MERGE] Eventarc Trigger Feb 10, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 32 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 13 files changed, 927 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171683"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 224 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 14 files changed, 985 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171772"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 224 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 13 files changed, 998 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172131"

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 224 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 13 files changed, 998 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172203"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 224 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 14 files changed, 999 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 4 files changed, 28 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173059"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173067"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccRedisInstance_redisInstancePrivateServiceExample Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants