Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventarc Trigger #2972

Conversation

modular-magician
Copy link
Collaborator

Add eventarc resource as the first DCL-based resource.

Lots of handwritten parts that can be cleaned up in the future when tpgtools+mmv1 are better integrated

Currently DCL-based resources fail VCR testing because the client is copied & saved during client creation, making us unable to swap during testing

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_eventarc_trigger

Derived from GoogleCloudPlatform/magic-modules#4476

* Add support for eventarc through DCL

* Add correct path to test

* Skip VCR, add dcl.go

* Fix validator compile

* Add function only for beta for now

* Compile transport for validator

* Move around some code to allow for inheriting computed status from parent

* Disable website generation

* Removing override

* Add better default set func

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/xxl labels Feb 18, 2021
@modular-magician modular-magician merged commit 1c2d93f into hashicorp:master Feb 18, 2021
@modular-magician modular-magician deleted the downstream-pr-f9f30ad2081b4d72af9dc232cd0414afa2e6f2dd branch November 16, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant