-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support healthcare dicom bq stream configure #4717
Conversation
…-modules into chaopeng/master
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183262" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaopeng thanks for the PR! Could you please update the release note according to the guidelines in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md? Thanks!
mmv1/templates/terraform/examples/healthcare_dicom_store_bq_stream.tf.erb
Show resolved
Hide resolved
@melinath please run /gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183275" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183276" |
Tests failed during RECORDING mode: TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR |
mmv1/templates/terraform/examples/healthcare_dicom_store_bq_stream.tf.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183436" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183439" |
Tests failed during RECORDING mode: TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183555" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183588" |
Tests failed during RECORDING mode: TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample Please fix these to complete your PR |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183615" |
/gcbrun - failure was unrelated. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183616" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183619" |
@melinath could you please share me the failure? Thank you. #4717 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the tests are all passing, so this should be good to go from that perspective. It looks like the tests use a hard-coded dataset id now; will that be an issue? It looks like that field is supposed to be a unique ID but it's not clear whether that's globally unique or within the project. It looks like the bigquery_dataset tests use a context var instead.
mmv1/templates/terraform/examples/healthcare_dicom_store_bq_stream.tf.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183622" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183636" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
healthcare dicom bq stream configure is on beta now.
Link: https://cloud.google.com/healthcare/docs/how-tos/dicom-bigquery-streaming#healthcare-streaming-dicom-metadata-cli-curl
fixes hashicorp/terraform-provider-google#8958
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)