Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support healthcare dicom bq stream configure #3190

Conversation

modular-magician
Copy link
Collaborator

healthcare dicom bq stream configure is on beta now.

Link: https://cloud.google.com/healthcare/docs/how-tos/dicom-bigquery-streaming#healthcare-streaming-dicom-metadata-cli-curl
fixes hashicorp/terraform-provider-google#8958

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

healthcare: support bq stream configure in google_healthcare_dicom_store

Derived from GoogleCloudPlatform/magic-modules#4717

* Change healthcare consent API to GA support

* rebase update

* fix import format

* add fully quantified reference to healthcare resource

* fix import tests

* add dicom bq stream support

* resolve comments

* update example

* fix bq table name

* fix bq ds name

* change bq ds name

Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/l label Apr 23, 2021
@modular-magician modular-magician merged commit db20835 into hashicorp:master Apr 23, 2021
@modular-magician modular-magician deleted the downstream-pr-e872c2d1f29c328f6d9541a6ddc0a9b26ca95df6 branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support healthcare dicom bq stream configure
1 participant