Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secret manager cmek #4752

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Apr 30, 2021

Upstreams hashicorp/terraform-provider-google#8976

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

secretmanager: added support for setting a CMEK on `google_secret_manager_secret` 

Co-authored-by: Sarath Kaul <kaul.sarath@gmail.com>
Co-authored-by: Cameron Thornton <camthornton@google.com>
@google-cla
Copy link

google-cla bot commented Apr 30, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@c2thorn
Copy link
Member Author

c2thorn commented Apr 30, 2021

@SKAUL05 mind taking a look at the google CLA?

@SKAUL05
Copy link
Contributor

SKAUL05 commented Apr 30, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 30, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 143 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185101"

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@c2thorn
Copy link
Member Author

c2thorn commented Apr 30, 2021

/gcbrun

@c2thorn c2thorn requested a review from megan07 April 30, 2021 17:19
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185102"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccSecretManagerSecret_cmek You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185104"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants