-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMEK to Google Secret Manager #8976
Conversation
@c2thorn Have you reviewed it yet? |
/gcbrun |
@c2thorn I think build didn't run or did it? |
Silly mistake on my part, I thought we were in https://github.com/GoogleCloudPlatform/magic-modules 🤣 Heads up, Magic Modules is our upstream repository that generates code for this resource. Changes made here will get overridden. I've added the field and your test in GoogleCloudPlatform/magic-modules#4752 and it looks mostly the same with a few minor differences (ordering). But everything seems to work. |
@@ -100,6 +100,18 @@ The `replicas` block supports: | |||
(Required) | |||
The canonical IDs of the location to replicate data. For example: "us-east1". | |||
|
|||
* `custom_managed_encryption` - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ended up needing to be customer_managed_encryption
The upstream PR will now get reviewed. If it's all the same to you, we can close this PR and let the upstream PR maintain any further changes if needed (I've added you as a co-author). |
Works for me! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes: #8917
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)