Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote logConfig of Healthchecks to GA #4822

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

upodroid
Copy link
Contributor

Forgot to apply #3861 to Regional Healthchecks too. That bug is causing diffs with HCs created for HTTPS ILBs

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `log_config` field of `google_compute_health_check` and `google_compute_region_health_check`
compute: set the default value for log_config.enable on `google_compute_region_health_check` to avoid permanent diff on plan/apply. 

Co-authored-by: upodroid <cy@borg.dev>
@google-cla google-cla bot added the cla: yes label May 28, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 143 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 3 insertions(+), 2 deletions(-))
Ansible: Diff ( 4 files changed, 110 insertions(+))
TF Conversion: Diff ( 2 files changed, 58 insertions(+))
Inspec: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=189639"

properties:
- !ruby/object:Api::Type::Boolean
name: 'enable'
description: |
Indicates whether or not to export logs. This is false by default,
which means no health check logging will be done.
default_value: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we change this when GAing the fields?

It feels dangerous to change default values for no reason, can we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm applying the fix from #3861

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the fix is more important the promotion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok it's a region/zone thing that got missed previously. Makes sense

@slevenick slevenick self-requested a review June 1, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants