Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote logConfig of Healthchecks to GA #3291

Conversation

modular-magician
Copy link
Collaborator

Forgot to apply #3861 to Regional Healthchecks too. That bug is causing diffs with HCs created for HTTPS ILBs

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `log_config` field of `google_compute_health_check` and `google_compute_region_health_check`
compute: set the default value for log_config.enable on `google_compute_region_health_check` to avoid permanent diff on plan/apply. 

Derived from GoogleCloudPlatform/magic-modules#4822

Co-authored-by: upodroid <cy@borg.dev>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Jun 1, 2021
@modular-magician modular-magician merged commit fb162e7 into hashicorp:master Jun 1, 2021
@modular-magician modular-magician deleted the downstream-pr-748b8a9678be1906d31b09e0b686eba561e30ac9 branch November 16, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant