Allow redisVersion to change, promoted some fields to GA

[ScottSuarez]

closes hashicorp/terraform-provider-google#9174
closes hashicorp/terraform-provider-google#8306

Allow redis_version to be updated.
Promoted transit_encryption_mode and server_ca_certs to GA

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

redis: allowed `redis_version` to be upgraded on `google_redis_instance`

redis: promoted fields `transit_encryption_mode` and `server_ca_certs` to GA on `google_redis_instance` (GA)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 129 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190230"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample|TestAccComputeRouter_computeRouterEncryptedInterconnectExample|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceAuthEnabled You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190332"

[slevenick]

We talked offline about this, but I don't believe this actually tests that the version can be updated. That test forces recreation by changing region so no fields are updated in-place

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 495 insertions(+), 134 deletions(-))
Terraform Beta: Diff ( 37 files changed, 395 insertions(+), 148 deletions(-))
Ansible: Diff ( 2 files changed, 129 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191389"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 34 files changed, 495 insertions(+), 134 deletions(-))
Terraform Beta: Diff ( 37 files changed, 395 insertions(+), 148 deletions(-))
Ansible: Diff ( 2 files changed, 129 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191390"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 149 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 43 insertions(+), 4 deletions(-))
Ansible: Diff ( 3 files changed, 131 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191394"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeBackendService_withSecurityPolicy|TestAccInstanceGroupManager_waitForStatus|TestAccComputePerInstanceConfig_update|TestAccComputeRegionPerInstanceConfig_update|TestAccHealthcareDataset_basic|TestAccHealthcareDicomStore_basic|TestAccHealthcareFhirStore_basic|TestAccHealthcareHl7V2Store_basic|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccTags You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191396"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable|TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeBackendService_withSecurityPolicy|TestAccInstanceGroupManager_waitForStatus|TestAccComputePerInstanceConfig_update|TestAccComputeRegionPerInstanceConfig_update|TestAccHealthcareDataset_basic|TestAccHealthcareDicomStore_basic|TestAccHealthcareFhirStore_basic|TestAccHealthcareHl7V2Store_basic|TestAccRedisInstance_redisInstanceAuthEnabled You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191397"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccRedisInstance_redisInstanceAuthEnabled You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191399"

[ScottSuarez]

@slevenick should be good to go

[slevenick]

Looks like you're getting rake test errors:

provider/core.rb:331:22: C: Style/InverseMethods: Use select instead of inverting reject.
      update_props = properties.reject do |p| ...
                     ^^^^^^^^^^^^^^^^^^^^^^^^

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191597"

[slevenick]

Looks like you have a typo causing a linting error.

I'm a little concerned about changing the PATCH behavior if the update mask is empty. I wonder how often this happens. We can look at the VCR tests that fail for this run to get a signal on that

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 336 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 3 files changed, 230 insertions(+), 20 deletions(-))
Ansible: Diff ( 3 files changed, 131 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191799"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 336 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 3 files changed, 230 insertions(+), 20 deletions(-))
Ansible: Diff ( 3 files changed, 131 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191803"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191904"

[slevenick]

Looks like a test is failing with:

Error: Instance cannot be destroyed
on terraform_plugin_test.tf line 2:
2: resource "google_redis_instance" "test" {
Resource google_redis_instance.test has lifecycle.prevent_destroy set, but the
plan calls for this resource to be destroyed. To avoid this error and continue
with the plan, either disable lifecycle.prevent_destroy or reduce the scope of
the plan using the -target flag.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 335 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 3 files changed, 229 insertions(+), 20 deletions(-))
Ansible: Diff ( 3 files changed, 131 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
Inspec: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192081"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstance_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192091"

[slevenick]

Can you check to see why server_ca_certs didn't change in the downstream markdown? Is that intentional?

[ScottSuarez]

Apparently we don't put beta it its not an input field 😬

https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/templates/terraform/property_documentation.erb#L4-L8