Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redisVersion to change, promoted some fields to GA #3344

Conversation

modular-magician
Copy link
Collaborator

closes hashicorp/terraform-provider-google#9174
closes hashicorp/terraform-provider-google#8306

Allow redis_version to be updated.
Promoted transit_encryption_mode and server_ca_certs to GA

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

redis: allowed `redis_version` to be upgraded on `google_redis_instance`
redis: promoted fields `transit_encryption_mode` and `server_ca_certs` to GA on `google_redis_instance` (GA)

Derived from GoogleCloudPlatform/magic-modules#4838

)

* Allow redisVersion to change, promoted some fields to GA

* allow updating properties if update method is defined at the field level

* upgrade post url

* fix current resources to not reference url

* add support for forceNew if version is shrinking

* don't send request if not updating anything.. request fails if update mask is empty.. also add more tests

* fix spelling mistake

* fix rake issues

* remove transcription mode... forces new on change

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 2a8a585 into hashicorp:master Jun 15, 2021
@modular-magician modular-magician deleted the downstream-pr-5de9a42b14c4672a96b147dedfd28bb174b51b62 branch November 16, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant