-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added internal HTTPS load balancer example with http-to-https redirect #5248
Added internal HTTPS load balancer example with http-to-https redirect #5248
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this might be breaking the compiler somehow. Are you able to generate the docs examples and/or the providers locally?
(If you're able to compile everything fine locally, you could try merging master / rebasing to get the latest changes in case that helps.) |
f02c698
to
5b9d416
Compare
I get these errors because the path to the files isn't valid. I thought this might work because https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/templates/terraform/examples/region_target_https_proxy_basic.tf.erb#L8-L13
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 263 insertions(+)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionUrlMap_intHttpsLbHttpsRedirectExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207927 |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 263 insertions(+)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 267 insertions(+)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 299 insertions(+)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 297 insertions(+)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 297 insertions(+)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 294 insertions(+)) |
It seems to be working now. My test is successful. |
It's working fine now, I think |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 294 insertions(+)) |
Fixed. |
fixed |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 294 insertions(+)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccComputeRegionBackendService_intHttpsLbHttpsRedirectExample|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208311 |
Tests failed during RECORDING mode: TestAccComputeRegionBackendService_intHttpsLbHttpsRedirectExample Please fix these to complete your PR |
mmv1/products/compute/terraform.yaml
Outdated
@@ -335,6 +335,31 @@ overrides: !ruby/object:Overrides::ResourceOverrides | |||
default_from_api: true | |||
RegionBackendService: !ruby/object:Overrides::Terraform::ResourceOverride | |||
examples: | |||
- !ruby/object:Provider::Terraform::Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this Example towards the bottom of the examples block? The order listed here is how they will appear in the documentation, and we should generally have the basic version of the resource listed first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 294 insertions(+)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionUrlMap_intHttpsLbHttpsRedirectExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208483 |
Intending to add this example to this page:
https://cloud.google.com/load-balancing/docs/l7-internal/int-https-lb-tf-examples