Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added internal HTTPS load balancer example with http-to-https redirect #5248

Merged
merged 14 commits into from
Oct 1, 2021

Conversation

betsy-lichtenberg
Copy link
Contributor

@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this might be breaking the compiler somehow. Are you able to generate the docs examples and/or the providers locally?

@melinath
Copy link
Member

(If you're able to compile everything fine locally, you could try merging master / rebasing to get the latest changes in case that helps.)

@betsy-lichtenberg
Copy link
Contributor Author

I get these errors because the path to the files isn't valid. I thought this might work because https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/templates/terraform/examples/region_target_https_proxy_basic.tf.erb#L8-L13

Error: Invalid function argument
│ 
│   on int_https_lb_https_redirect.tf line 62, in resource "google_compute_region_ssl_certificate" "default":
│   62:   private_key = file("path/to/private.key")
│ 
│ Invalid value for "path" parameter: no file exists at path/to/private.key; this function works only with files that are distributed as
│ part of the configuration source code, so if this file will be created by a resource in this configuration you must instead obtain this
│ result from an attribute of that resource.
╵
╷
│ Error: Invalid function argument
│ 
│   on int_https_lb_https_redirect.tf line 63, in resource "google_compute_region_ssl_certificate" "default":
│   63:   certificate = file("path/to/certificate.crt")

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 263 insertions(+))
Terraform Beta: Diff ( 2 files changed, 546 insertions(+))
TF OiCS: Diff ( 4 files changed, 354 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 255 insertions(+))

@melinath melinath self-requested a review September 28, 2021 22:09
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionUrlMap_intHttpsLbHttpsRedirectExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207927

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 263 insertions(+))
Terraform Beta: Diff ( 3 files changed, 547 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 354 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 255 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 267 insertions(+))
Terraform Beta: Diff ( 4 files changed, 557 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 358 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 259 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 299 insertions(+))
Terraform Beta: Diff ( 3 files changed, 620 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 390 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 291 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 297 insertions(+))
Terraform Beta: Diff ( 3 files changed, 615 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 388 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 289 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 297 insertions(+))
Terraform Beta: Diff ( 2 files changed, 614 insertions(+))
TF OiCS: Diff ( 4 files changed, 388 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 289 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 294 insertions(+))
Terraform Beta: Diff ( 2 files changed, 608 insertions(+))
TF OiCS: Diff ( 4 files changed, 385 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 286 insertions(+))

@betsy-lichtenberg
Copy link
Contributor Author

(If you're able to compile everything fine locally, you could try merging master / rebasing to get the latest changes in case that helps.)

It seems to be working now. My test is successful.

@betsy-lichtenberg
Copy link
Contributor Author

It looks like this might be breaking the compiler somehow. Are you able to generate the docs examples and/or the providers locally?

It's working fine now, I think

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 294 insertions(+))
Terraform Beta: Diff ( 2 files changed, 608 insertions(+))
TF OiCS: Diff ( 4 files changed, 385 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 286 insertions(+))

@betsy-lichtenberg
Copy link
Contributor Author

It looks like this might be breaking the compiler somehow. Are you able to generate the docs examples and/or the providers locally?

Fixed.

@betsy-lichtenberg
Copy link
Contributor Author

It looks like this might be breaking the compiler somehow. Are you able to generate the docs examples and/or the providers locally?

fixed

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 294 insertions(+))
Terraform Beta: Diff ( 2 files changed, 608 insertions(+))
TF OiCS: Diff ( 4 files changed, 385 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 286 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccComputeRegionBackendService_intHttpsLbHttpsRedirectExample|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208311

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeRegionBackendService_intHttpsLbHttpsRedirectExample Please fix these to complete your PR

@@ -335,6 +335,31 @@ overrides: !ruby/object:Overrides::ResourceOverrides
default_from_api: true
RegionBackendService: !ruby/object:Overrides::Terraform::ResourceOverride
examples:
- !ruby/object:Provider::Terraform::Examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this Example towards the bottom of the examples block? The order listed here is how they will appear in the documentation, and we should generally have the basic version of the resource listed first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 294 insertions(+))
Terraform Beta: Diff ( 3 files changed, 609 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 385 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 286 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionUrlMap_intHttpsLbHttpsRedirectExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208483

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 289 insertions(+))
Terraform Beta: Diff ( 1 file changed, 289 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 286 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants