-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add CDN load balancer with Cloud Storage buckets as backend" #5690
Revert "Add CDN load balancer with Cloud Storage buckets as backend" #5690
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Looking into it, it probably fails because we don't support hashicorp/terraform-provider-google#10202 looks like it was primarily made for cloud.google.com samples, and generated here: https://github.com/terraform-google-modules/terraform-docs-samples/tree/master/external_cnd_lb_with_backend_bucket This is a similar situation as #5248, where we just added the |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 145 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to revert after discussion.
Reverts #5575
This test doesn't pass due to external providers. Removing until it can pass